Add locking around ops that change template router state.#8893
Add locking around ops that change template router state.#8893openshift-bot merged 1 commit intoopenshift:masterfrom
Conversation
pkg/router/template/router.go
Outdated
| return false | ||
| } | ||
|
|
||
| r.lock.Lock() |
There was a problem hiding this comment.
Find service unit does not make a copy, so this is not safe.
There was a problem hiding this comment.
Unless we also guarantee that we make no mutations to state. Is that the case?
There was a problem hiding this comment.
Hmm, might be better to separate FindServiceUnit into an internal/external part - that way all the internal calls can work thru' in a lock. Let me redo this. Thx
lockless eventually and use a "shadow" (cloned) copy of the config when we do a reload. o Fixes as per @smarterclayton review comments.
|
[test] |
|
Changes look good to me - will wait for clean run and then apply label. |
|
@deads2k you are pinged re: test basic controller workflow test
|
|
re[test] Another failure in the test flow, still haven't seen one in merge. I think I'll try bumping the timeout. Maybe someone's parallel test-cmd and test-go makes things extra slow. |
|
Evaluated for origin test up to 6a47777 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3882/) |
|
[merge] Lgtm |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5934/) (Image: devenv-rhel7_4225) |
|
Evaluated for origin merge up to 6a47777 |
4 participants
fixes #8825
@liggitt PTAL