oc set env must respect --overwrite=false#9495
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Jun 23, 2016
Merged
oc set env must respect --overwrite=false#9495openshift-bot merged 1 commit intoopenshift:masterfrom
openshift-bot merged 1 commit intoopenshift:masterfrom
Conversation
Member
Author
|
[test] |
fabianofranz
force-pushed
the
bugs_1304251
branch
from
333a66c to
5c74a7a
Compare
Contributor
|
Evaluated for origin test up to 5c74a7a |
Contributor
|
LGTM |
Contributor
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5299/) |
Member
Author
|
[merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5299/) (Image: devenv-rhel7_4444) |
Contributor
|
Evaluated for origin merge up to 5c74a7a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1304251.
--overwrite=trueis the default, but when--overwrite=falseis provided we need to validate.@smarterclayton please review.