Skip to content

gitmodules: track rhcos-4.13 branch#1186

Closed
mike-nguyen wants to merge 2 commits intoopenshift:release-4.13from
mike-nguyen:rhcos4.13_fcc_submodule
Closed

gitmodules: track rhcos-4.13 branch#1186
mike-nguyen wants to merge 2 commits intoopenshift:release-4.13from
mike-nguyen:rhcos4.13_fcc_submodule

Conversation

@mike-nguyen
Copy link
Copy Markdown
Member

@mike-nguyen mike-nguyen commented Mar 8, 2023

Have the submodule track the rhcos-4.13 branch on the fedora-coreos-config repo as a part of the 4.13 branching.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 8, 2023

@mike-nguyen: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

gitmodules: track rhcos-4.13 branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from aaradhak and marmijo March 8, 2023 17:55
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2023
@mike-nguyen mike-nguyen force-pushed the rhcos4.13_fcc_submodule branch from 4563b92 to 97c655f Compare March 8, 2023 18:00
@mike-nguyen
gitmodules: track rhcos-4.13 branch
50333ac 
Start tracing the rhcos-4.13 branch of fedora-coreos-config as a
part of branching for 4.13.
@mike-nguyen mike-nguyen force-pushed the rhcos4.13_fcc_submodule branch from 97c655f to 3a3655f Compare March 8, 2023 18:31
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Mar 8, 2023

Thanks for adding the shortlog!

/lgtm

This includes coreos/fedora-coreos-config#2272 which should allow us to also drop the luks.* denylist entry. Do you want to do that in this PR or leave it as a follow-up? Feel free to drop the hold if the latter.

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2023
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2023
marmijo
marmijo approved these changes Mar 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-nguyen
Copy link
Copy Markdown
Member Author

mike-nguyen commented Mar 14, 2023 •
edited
Loading

Thanks for adding the shortlog!

/lgtm

This includes coreos/fedora-coreos-config#2272 which should allow us to also drop the luks.* denylist entry. Do you want to do that in this PR or leave it as a follow-up? Feel free to drop the hold if the latter.

/hold

@jlebon can we drop this for all arches? Current denylist entry is

- pattern: luks.*
  tracker: https://github.com/openshift/os/issues/1149
  arches:
   - ppc64le
   - aarch64
   - s390x

EDIT: I see #1193, I will just create a separate PR once that merges into main.

/hold cancel

@mike-nguyen
Copy link
Copy Markdown
Member Author

mike-nguyen commented Mar 14, 2023

/retest

@jlebon jlebon mentioned this pull request Mar 14, 2023
Merged
@mike-nguyen
Copy link
Copy Markdown
Member Author

mike-nguyen commented Mar 14, 2023

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2023
@mike-nguyen
Copy link
Copy Markdown
Member Author

mike-nguyen commented Mar 14, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 14, 2023
@mike-nguyen
Copy link
Copy Markdown
Member Author

mike-nguyen commented Mar 14, 2023

/retest

@mike-nguyen
Copy link
Copy Markdown
Member Author

mike-nguyen commented Mar 15, 2023

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 15, 2023 •
edited
Loading

@mike-nguyen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos-86-build-test-qemu 3a3655f link true /test rhcos-86-build-test-qemu
ci/prow/rhcos-90-build-test-metal 3a3655f link true /test rhcos-90-build-test-metal
ci/prow/rhcos-86-build-test-metal 3a3655f link true /test rhcos-86-build-test-metal
ci/prow/rhcos-90-build-test-qemu 3a3655f link true /test rhcos-90-build-test-qemu

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mike-nguyen
bump f-c-c submodule to track rhcos-4.13 branch
c0f0665 
```
git shortlog --no-merges d170f19..f00040e1616ef244dfe622cad50b876d8087039e

Adam Piasecki (1):
      tests/kola/selinux/enforcing: Enhance SELinux mode test

Adam0Brien (1):
      F38 Changes: Kola test for shorter shutdown timer

CoreOS Bot (6):
      lockfiles: bump to latest
      lockfiles: bump to latest
      lockfiles: drop graduated overrides 🎓
      Sync repo templates ⚙
      lockfiles: bump to latest
      lockfiles: bump to latest

Dusty Mabe (4):
      tests/kola: add version comparison functions to commonlib.sh
      tests/kola: mark systemd.default-unit-timeouts as platform-independent
      tests/kola: break up long line in systemd.default-unit-timeouts
      denylist: bump snooze for files.file-directory-permissions

Huijing Hei (1):
      transposefs: add new workaround using try in loop

Jonathan Lebon (1):
      ci: update for new kolaTestIso()

gursewak1997 (2):
      Move chrony config from generator to systemd service
      platform-chrony: Make /run/coreos dir so we can create platform-chrony.conf
```
@mike-nguyen mike-nguyen force-pushed the rhcos4.13_fcc_submodule branch from 3a3655f to c0f0665 Compare March 15, 2023 16:16
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
@mike-nguyen
Copy link
Copy Markdown
Member Author

mike-nguyen commented Mar 15, 2023

Forced push to reset CI which was updated between when this PR was opened and now.

@mike-nguyen
Copy link
Copy Markdown
Member Author

mike-nguyen commented Mar 15, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 15, 2023
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Mar 15, 2023

/lgtm

Note coreos/fedora-coreos-config#2301 was just merged this morning. Might be easier to just bump the submodule again here instead of doing it as a separate PR and going through CI. But fine as is too; this PR already has been waiting for a while.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, marmijo, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [jlebon,marmijo,mike-nguyen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mike-nguyen
Copy link
Copy Markdown
Member Author

mike-nguyen commented Mar 15, 2023

Closing. Looks like this was covered by #1198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaradhak aaradhak Awaiting requested review from aaradhak

1 more reviewer

@marmijo marmijo marmijo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jlebon jlebon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mike-nguyen @jlebon @marmijo