Skip to content

[4.13] Backports from 4.14#1198

Merged
cgwalters merged 7 commits intoopenshift:release-4.13from
travier:4.13-backports
Mar 15, 2023
Merged

[4.13] Backports from 4.14#1198
cgwalters merged 7 commits intoopenshift:release-4.13from
travier:4.13-backports

Conversation

@travier
Copy link
Copy Markdown
Member

@travier travier commented Mar 14, 2023

manifest/9.2: Ensure package come from RHEL by default

Make sure that we use RHEL (and not RHAOS) packages by default.

(cherry picked from commit 49f9824)


overlay: Remove unused 25rhcos-azure-udev-rules

Not needed (and not actually used right now) in RHEL 8.6+ anymore.

(cherry picked from commit 5d5d0c5)


Bump fedora-coreos-config

Adam Piasecki (1):
tests/kola/selinux/enforcing: Enhance SELinux mode test

Adam0Brien (1):
F38 Changes: Kola test for shorter shutdown timer

Benjamin Gilbert (2):
tests/kola: add test for custom SSH host key with mode 640
denylist: drop snoozes for Ignition spec bump

Dusty Mabe (6):
tests/kola: add version comparison functions to commonlib.sh
tests/kola: mark systemd.default-unit-timeouts as platform-independent
tests/kola: break up long line in systemd.default-unit-timeouts
denylist: bump snooze for files.file-directory-permissions
platforms.yaml: Add serial console information for KubeVirt platform.
denylist: drop snooze for ext.config.platforms.aws.nvme

Huijing Hei (1):
transposefs: add new workaround using try in loop

Jonathan Lebon (1):
ci: update for new kolaTestIso()

gursewak1997 (4):
Move chrony config from generator to systemd service
platform-chrony: Make /run/coreos dir so we can create platform-chrony.conf
denylist: bump snooze for kdump.crash
denylist: drop extensions.module from denylist Ref: coreos/fedora-coreos-tracker#1420 (comment)

(cherry picked from commit 3b0d0c7)


denylist: Skip ext.config.shared.ignition.resource.remote

See #1190

(cherry picked from commit d47155a)


s390x/kola-denylist: Re-enable working tests

fips.enable* is working on newest s390x. Remove the test from denylist.
For more details see #546

coreos.ignition.mount.* is fixed with gdisk-1.0.3-9.el8. Remove the test from
denylist.

ext.config.shared.ignition.stable-boot is fixed in RHEL 9. Only disable for
RHEL 8 builds.

Signed-off-by: Jan Schintag jan.schintag@de.ibm.com
(cherry picked from commit 36729d1)


Revert "tests: Add skip-console-warnings to global kola config"

Fixes: #1160
See: #1128
See: https://bugzilla.redhat.com/show_bug.cgi?id=2164765

This reverts commit 010cb8b.

(cherry picked from commit 2419a93)

travier added 2 commits March 14, 2023 18:35
Make sure that we use RHEL (and not RHAOS) packages by default.

(cherry picked from commit 49f9824)
Not needed (and not actually used right now) in RHEL 8.6+ anymore.

(cherry picked from commit 5d5d0c5)
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2023
@travier travier changed the base branch from master to release-4.13 March 14, 2023 17:37
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 14, 2023

@travier: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[4.13] Backports from 4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2023
@openshift-ci openshift-ci Bot requested review from Adam0Brien and HuijingHei March 14, 2023 17:38
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 14, 2023

@jlebon
Copy link
Copy Markdown
Member

jlebon commented Mar 14, 2023

Hmm, this is backporting the f-c-c submodule bump from a more recent testing-devel, but I think we want #1186 instead to track rhcos-4.13. Maybe just drop that commit?

@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 14, 2023

Oh indeed, my bad.

@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 14, 2023

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2023
@mike-nguyen
Copy link
Copy Markdown
Member

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 14, 2023
@cgwalters
Copy link
Copy Markdown
Member

I think the denylist here also needs ignition.resource.remote until I think coreos/coreos-assembler#3387 is back to a coreos-assembler rhcos-4.13? I can't keep track of all the moving parts for this test and I feel like we should just ignore it.

aaradhak and others added 4 commits March 15, 2023 16:25
fips.enable* is working on newest s390x. Remove the test from denylist.
For more details see openshift#546

coreos.ignition.mount.* is fixed with gdisk-1.0.3-9.el8. Remove the test from
denylist.

ext.config.shared.ignition.stable-boot is fixed in RHEL 9. Only disable for
RHEL 8 builds.

Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
(cherry picked from commit 36729d1)
Start tracing the rhcos-4.13 branch of fedora-coreos-config as a
part of branching for 4.13.
```
git shortlog --no-merges d170f19..f00040e1616ef244dfe622cad50b876d8087039e

Adam Piasecki (1):
      tests/kola/selinux/enforcing: Enhance SELinux mode test

Adam0Brien (1):
      F38 Changes: Kola test for shorter shutdown timer

CoreOS Bot (6):
      lockfiles: bump to latest
      lockfiles: bump to latest
      lockfiles: drop graduated overrides 🎓
      Sync repo templates ⚙
      lockfiles: bump to latest
      lockfiles: bump to latest

Dusty Mabe (4):
      tests/kola: add version comparison functions to commonlib.sh
      tests/kola: mark systemd.default-unit-timeouts as platform-independent
      tests/kola: break up long line in systemd.default-unit-timeouts
      denylist: bump snooze for files.file-directory-permissions

Huijing Hei (1):
      transposefs: add new workaround using try in loop

Jonathan Lebon (1):
      ci: update for new kolaTestIso()

gursewak1997 (2):
      Move chrony config from generator to systemd service
      platform-chrony: Make /run/coreos dir so we can create platform-chrony.conf
```
@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 15, 2023

Pulled #1186 into this one.

@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 15, 2023

Also removed #1175 as it has not merged yet.

@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 15, 2023

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2023
@cgwalters
Copy link
Copy Markdown
Member

I think we still need to deny the ignition resource remote test?

Maintaining this test just requires way too much intricate
stuff to be chained together.
@cgwalters
Copy link
Copy Markdown
Member

I pushed a commit to do that
/lgtm
/approve

@cgwalters
Copy link
Copy Markdown
Member

Don't need to retest these things for denylists, and we rerun this stuff again anyways
/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemui
/override ci/prow/scos-9-build-test-metal
/override ci/prow/scos-9-build-test-qemu

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 15, 2023

@cgwalters: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ci/prow/rhcos-92-build-test-qemui

Only the following failed contexts/checkruns were expected:

  • ci/prow/images
  • ci/prow/rhcos-92-build-test-metal
  • ci/prow/rhcos-92-build-test-qemu
  • ci/prow/scos-9-build-test-metal
  • ci/prow/scos-9-build-test-qemu
  • ci/prow/validate
  • pull-ci-openshift-os-master-images
  • pull-ci-openshift-os-master-rhcos-92-build-test-metal
  • pull-ci-openshift-os-master-rhcos-92-build-test-qemu
  • pull-ci-openshift-os-master-scos-9-build-test-metal
  • pull-ci-openshift-os-master-scos-9-build-test-qemu
  • pull-ci-openshift-os-master-validate

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

Don't need to retest these things for denylists, and we rerun this stuff again anyways
/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemui
/override ci/prow/scos-9-build-test-metal
/override ci/prow/scos-9-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Copy Markdown
Member

/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu
/override ci/prow/scos-9-build-test-metal
/override ci/prow/scos-9-build-test-qemu

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 15, 2023

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/rhcos-92-build-test-metal, ci/prow/rhcos-92-build-test-qemu, ci/prow/scos-9-build-test-metal, ci/prow/scos-9-build-test-qemu

Details

In response to this:

/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu
/override ci/prow/scos-9-build-test-metal
/override ci/prow/scos-9-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Copy Markdown
Member

/override ci/prow/images

@cgwalters cgwalters merged commit a208eca into openshift:release-4.13 Mar 15, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 15, 2023

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/images

Details

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 15, 2023

@travier: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos-90-build-test-qemu 80e782f link true /test rhcos-90-build-test-qemu
ci/prow/rhcos-86-build-test-metal 80e782f link true /test rhcos-86-build-test-metal
ci/prow/rhcos-90-build-test-metal 80e782f link true /test rhcos-90-build-test-metal
ci/prow/rhcos-86-build-test-qemu 80e782f link true /test rhcos-86-build-test-qemu
ci/prow/images 6e41230 link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@travier travier deleted the 4.13-backports branch March 16, 2023 10:16
@cgwalters cgwalters mentioned this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[4.13-9.2] Revert: tests: Add skip-console-warnings to global kola config

7 participants