Ensure the AWS client is valid before its returned#126
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Jul 20, 2021
Merged
Ensure the AWS client is valid before its returned#126openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
the
approved
Contributor
|
/retest |
fahlmant
force-pushed
the
aws-invalid-creds-err
branch
from
b46e498 to
958dcc0
Compare
fahlmant
force-pushed
the
aws-invalid-creds-err
branch
from
958dcc0 to
f53d3db
Compare
iamkirkbater
approved these changes
Jul 20, 2021
Contributor
iamkirkbater
left a comment
iamkirkbater
left a comment
There was a problem hiding this comment.
/lgtm
Tested locally. Nice addition. Thanks @fahlmant!
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fahlmant, iamkirkbater The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
devppratik
pushed a commit
to devppratik/osdctl
that referenced
this pull request
Aug 23, 2023
Ensure the AWS client is valid before its returned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.