Skip to content

[cluster health] Condense cmd output for clarity#129

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
mmazur:output_clarity
Jul 21, 2021
Merged

[cluster health] Condense cmd output for clarity#129
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
mmazur:output_clarity

Conversation

@mmazur
Copy link
Member

@mmazur mmazur commented Jul 21, 2021

Output after this patch:

ID:         1m2q4ujh9s1tmmtmi5u641rcbbqrdskp
Name:       osde2e-229p0
Provider:   AWS
AZs:        [us-east-1a]
Nodes
  Expected: 9
  Running:  10

@openshift-ci openshift-ci bot requested review from clcollins and iamkirkbater July 21, 2021 11:40
@georgettica
Copy link
Contributor

you know, you could do that in a yaml object so it's parsable

@mmazur
Copy link
Member Author

mmazur commented Jul 21, 2021

you know, you could do that in a yaml object so it's parsable

Yeah and I'm sure this will be done properly at some point once the list of checks grows. For now I wanted it fast, so the thing is releasable and we can switch to using it asap.

@RiRa12621
Copy link

/hold
just because we need it quickly doesn't mean that it cannot be done properly.
@georgettica can you work with @mmazur to get a proper implementation of this?

@RiRa12621 RiRa12621 closed this Jul 21, 2021
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2021
@RiRa12621 RiRa12621 reopened this Jul 21, 2021
@mmazur
Copy link
Member Author

mmazur commented Jul 21, 2021

It can be done properly if somebody has time to do it before end of week. Otherwise it's more important to do it quickly.

Copy link
Contributor

@fahlmant fahlmant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 21, 2021
@mmazur
Copy link
Member Author

mmazur commented Jul 21, 2021

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2021

@mmazur: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fahlmant, mmazur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RiRa12621
Copy link

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit c82e581 into openshift:master Jul 21, 2021
tnierman pushed a commit to tnierman/osdctl that referenced this pull request Jul 23, 2021
[cluster health] Condense cmd output for clarity
devppratik pushed a commit to devppratik/osdctl that referenced this pull request Aug 23, 2023
[cluster health] Condense cmd output for clarity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants