Skip to content

chore(makefile): align mockgen versions#148

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
georgettica:georgettica/fix-mockgen-goget
Oct 28, 2021
Merged

chore(makefile): align mockgen versions#148
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
georgettica:georgettica/fix-mockgen-goget

Conversation

@georgettica
Copy link
Contributor

this caused a 'go-get' to be called and change the go.mod stuff

this change also changed some generated files

this caused a 'go-get' to be called and change the go.mod stuff

this change also changed some generated files
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2021
@georgettica
Copy link
Contributor Author

the issue looks as follows:

go get github.com/golang/mock/mockgen@v1.4.4
go get: installing executables with 'go get' in module mode is deprecated.
	To adjust and download dependencies of the current module, use 'go get -d'.
	To install using requirements of the current module, use 'go install'.
	To install ignoring the current module, use 'go install' with a version,
	like 'go install example.com/cmd@latest'.
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.
go get: downgraded github.com/golang/mock v1.5.0 => v1.4.4
go get: removed github.com/openshift/gcp-project-operator v0.0.0-20210818135501-58ea50451037

Copy link
Contributor

@fahlmant fahlmant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fahlmant, georgettica

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [fahlmant,georgettica]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 058c9a9 into openshift:master Oct 28, 2021
@georgettica georgettica deleted the georgettica/fix-mockgen-goget branch October 28, 2021 11:18
devppratik pushed a commit to devppratik/osdctl that referenced this pull request Aug 23, 2023
…kgen-goget

chore(makefile): align mockgen versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants