Skip to content

Fix promote saas command for backplane-api#543

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
AlexVulaj:fix-promote-backplane-api
Apr 2, 2024
Merged

Fix promote saas command for backplane-api#543
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
AlexVulaj:fix-promote-backplane-api

Conversation

@AlexVulaj
Copy link
Contributor

@AlexVulaj AlexVulaj commented Apr 2, 2024

Fixes the ability to run osdctl promote saas --serviceName backplane-api --osd.

Currently, running the above would give the following output:

$ osdctl promote saas --serviceName saas-backplane-api --osd
### Checking if service saas-backplane-api exists ###
Service saas-backplane-api found
SAAS Directory: /Users/alexvulaj/Workspace/app-interface/data/services/backplane/cicd/saas/saas-backplane-api.yaml
Error while promoting service: failed to get current git hash or service repo: production namespace not found for service saas-backplane-api

This is because none of the if-statements in the affected code match the structure of the backplane saas file in app-interface.

This PR adds a new clause to check for the correct fields.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

@AlexVulaj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@fahlmant fahlmant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@clcollins
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, clcollins, fahlmant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [AlexVulaj,clcollins,fahlmant]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7b53e4e into openshift:master Apr 2, 2024
@AlexVulaj AlexVulaj deleted the fix-promote-backplane-api branch April 2, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants