Add dry-run ability to servicelog posting#87
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom May 13, 2021
Merged
Add dry-run ability to servicelog posting#87openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
the
needs-rebase
openshift-ci
bot
removed
the
needs-rebase
dastergon
suggested changes
May 13, 2021
Contributor
dastergon
left a comment
dastergon
left a comment
There was a problem hiding this comment.
/lgtm
Added a few recommendations so we can have a graceful process shutdown.
Contributor
|
/lgtm |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clcollins, dastergon, mrbarge The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
devppratik
pushed a commit
to devppratik/osdctl
that referenced
this pull request
Aug 23, 2023
Add dry-run ability to servicelog posting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
--dry-runparameter toosdctl servicelog postthat prints the contents of the servicelog that would be posted, without actually posting it.With some templates featuring multiple parameters comprising a sentence, I've found a dry-run desirable in order to be able to re-read a servicelog before I actually post it to ensure it makes grammatical sense.