Fix FormattedLog to include all commits, use oneline short-hash format

[gvnnn]

The go-git rewrite of FormattedLog inadvertently filtered commits to only those touching the resource template file. Restore the original behavior of showing all non-merge commits between the two hashes. Switch output from full commit format to oneline with 7-char short hashes.

Summary by CodeRabbit

• Improvements
  • Refactored commit log display format during promotion operations for enhanced readability. Commit hashes now appear in shortened form (7 characters) in promotion-generated commit messages, making them more concise and easier to scan.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e6fa3e7f-73f9-4ac1-98cd-80f7457acbe3

📥 Commits

Reviewing files that changed from the base of the PR and between b8e0cd1 and 259573b.

📒 Files selected for processing (7)

• cmd/promote/managedscripts/managed_scripts_test.go
• cmd/promote/saas/saas_test.go
• pkg/promote/git_repo.go
• pkg/promote/git_repo_test.go
• pkg/promote/service.go
• pkg/promote/service_test.go
• pkg/promote/test_tools.go

---

Walkthrough

Promotion commit-log generation now returns simplified entries with seven-character hashes and first-line commit messages. Promotion wiring and related managed-scripts, SaaS, and service tests were updated to use and verify the revised output.

Changes

Promotion commit log updates

Layer / File(s)	Summary
Simplify repository log generation pkg/promote/git_repo.go, pkg/promote/git_repo_test.go	Repo.FormattedLog no longer accepts a file path or filters commits by file stats; it emits short-hash commit entries and tests ancestor and non-merge traversal behavior.
Wire formatted logs into promotion messages pkg/promote/service.go, pkg/promote/test_tools.go	Promotion message construction uses the revised FormattedLog signature, while test log formatting uses seven-character hashes and single-line entries.
Update promotion scenarios cmd/promote/managedscripts/managed_scripts_test.go, cmd/promote/saas/saas_test.go, pkg/promote/service_test.go	Promotion test expectations were updated for the revised commit-log contents and selected hash sequences.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: FormattedLog now includes all commits and uses a one-line short-hash format.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All Ginkgo titles in the changed test files are static/descriptive; none interpolate hashes, names, dates, or other dynamic values.
Test Structure And Quality	✅ Passed	Touched Ginkgo tests use BeforeEach/AfterEach cleanup, no cluster waits/timeouts, and each It stays focused on one promote/log behavior.
Microshift Test Compatibility	✅ Passed	New Ginkgo specs only exercise local git helpers; changed tests contain no OpenShift/MicroShift APIs, namespaces, or unsupported features.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The added/modified Ginkgo tests are repo/file unit tests; they only inspect git logs and YAML content, with no node/topology or HA assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	Only promotion/git-log helpers and tests changed; no manifests, controllers, or pod scheduling constraints were introduced.
Ote Binary Stdout Contract	✅ Passed	Touched files only add helper/test changes; TestSetup funcs call RunSpecs without printing, and no stdout writes were added in main/init/TestMain or suite setup.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	New Ginkgo specs are unit tests using local git fixtures only; no IPv4-only addressing or external network calls were added.
No-Weak-Crypto	✅ Passed	No weak-crypto APIs or secret comparisons appear in the changed files; the edits only format git commit hashes and commit messages.
Container-Privileges	✅ Passed	Touched files are Go-only, and repo search found no privileged/container-escape settings in the diff.
No-Sensitive-Data-In-Logs	✅ Passed	PASS: FormattedLog now emits only 7-char hashes and commit subjects; the old template with author email/date/full hashes was removed, reducing exposure.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

@gvnnn: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[joshbranham]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gvnnn, joshbranham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [gvnnn,joshbranham]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment