SDCICD-129: Update metadata json file upon every metadata instance change#214
Conversation
openshift-ci-robot
added
size/M
mdwn
left a comment
mdwn
left a comment
There was a problem hiding this comment.
One question, but curious about your thoughts on this.
| @@ -40,6 +42,58 @@ func init() { | |||
| Instance = &Metadata{} | |||
There was a problem hiding this comment.
As a thought, should we not export Instance here and elevate all of the setters to package level?
I'm +0 to this, just wondering your thoughts.
There was a problem hiding this comment.
I feel like the way it is now is more intuitive? I dunno.
I get the idea I'm just +0 to it as well. And if we're both +0 I think maybe we let it slide?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeefy, meowfaceman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
No description provided.