Reduce sleep time in "inhibits ClusterOperatorDegraded" unit test in osde2e inhibitions suite#2952
Reduce sleep time in "inhibits ClusterOperatorDegraded" unit test in osde2e inhibitions suite#2952openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom btoll:OSD-30365
osde2e inhibitions suite#2952Conversation
…`osde2e` inhibitions suite The `time.Sleep` in this test is currently set to 10 minutes. This seems gratuitous and should be reduced, if possible. This came on our radar because of the ticket https://issues.redhat.com/browse/OSD-29225, which fixes an issue where the first unit test defined in the `inhibitions` suite was consistently failing due to the unit test attempting to do a deep equality check on slices of different types. See this document to learn how to test this locally: https://gitlab.cee.redhat.com/insight-global/docs/-/blob/master/osde2e.md
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
/override "Red Hat Konflux / osde2e-enterprise-contract / osde2e-main" |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: btoll, christophermancini, jbpratt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@jbpratt: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "Red Hat Konflux / osde2e-enterprise-contract / osde2e-main" |
|
@jbpratt: Overrode contexts on behalf of jbpratt: Red Hat Konflux / osde2e-enterprise-contract / osde2e-main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@btoll: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
The
time.Sleepin this test is currently set to 10 minutes. This seems gratuitous and should be reduced, if possible.This came on our radar because of the ticket
https://issues.redhat.com/browse/OSD-29225, which fixes an issue where the first unit test defined in the
inhibitionssuite was consistently failing due to the unit test attempting to do a deep equality check on slices of different types.This was tested locally. See this document to learn how to test this locally: https://gitlab.cee.redhat.com/insight-global/docs/-/blob/master/osde2e.md
https://issues.redhat.com/browse/OSD-30365