Skip to content

Run os tests on build02#16193

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
hongkailiu:fix_os_test
Feb 23, 2021
Merged

Run os tests on build02#16193
openshift-merge-robot merged 1 commit into
openshift:masterfrom
hongkailiu:fix_os_test

Conversation

@hongkailiu
Copy link
Copy Markdown
Member

It is moved by
1370d6a#diff-58bf6ae796976a0dbded9e4753ef25841eabbaf24de54a59d45f05c5884c9044L521

It is moved by the dispatcher because it was in .buildFarm[aws][build02].paths. The tool will reassign .buildFarm.

The correct place to fix a job on build02 is: .groups[build02].paths or put the job name in .groups[build02].jobs.

/cc @cgwalters

It is moved by
openshift@1370d6a#diff-58bf6ae796976a0dbded9e4753ef25841eabbaf24de54a59d45f05c5884c9044L521

It is moved by the dispatcher because it was in `.buildFarm[aws][build02].paths`. The tool will reassign `.buildFarm`.

The correct place to fix a job on build02 is: `.groups[build02].paths` or put the job name in `.groups[build02].jobs`.
@cgwalters
Copy link
Copy Markdown
Member

Thanks!
/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, hongkailiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 23, 2021

@hongkailiu: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/os/master/unit dd59356 link /test pj-rehearse
ci/prow/pj-rehearse dd59356 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgwalters
Copy link
Copy Markdown
Member

I think rehearsal will fail because the rehearse process doesn't know how to use the overrides from this repo or so?

@hongkailiu
Copy link
Copy Markdown
Member Author

I think rehearsal will fail because the rehearse process doesn't know how to use the overrides from this repo or so?

The rehearsal runs on build02 too. The test would hit the same thing.

- periodic-ipi-deprovision
paths:
- .*-postsubmits.yaml$
- openshift/os/.*-presubmits.yaml$
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be openshift-os-.*presubmits.yaml ? I.e. - instead of /?

Copy link
Copy Markdown
Member Author

@hongkailiu hongkailiu Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the regex to match the path (relative to ci-operator/jobs).

@openshift-merge-robot openshift-merge-robot merged commit 4de9a50 into openshift:master Feb 23, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@hongkailiu: Updated the following 2 configmaps:

  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-os-master-presubmits.yaml using file ci-operator/jobs/openshift/os/openshift-os-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-os-master-presubmits.yaml using file ci-operator/jobs/openshift/os/openshift-os-master-presubmits.yaml
Details

In response to this:

It is moved by
1370d6a#diff-58bf6ae796976a0dbded9e4753ef25841eabbaf24de54a59d45f05c5884c9044L521

It is moved by the dispatcher because it was in .buildFarm[aws][build02].paths. The tool will reassign .buildFarm.

The correct place to fix a job on build02 is: .groups[build02].paths or put the job name in .groups[build02].jobs.

/cc @cgwalters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Copy Markdown
Member

OK so one thing I noticed is that openshift/os#506 (comment) - so it's not "our nested virt CI is broken", it's just openshift/os

so @hongkliu this makes me suspicious of #16193 - I notice we e.g. don't have coreos/rpm-ostree CI in that latter list

It looks like that regexp is steering the job to app.ci ? Could that be the problem?

At a much higher level I don't understand how this YAML file is maintained and works and what the bots automatically generating it are doing - some sort of a comment at the top with a brief description would help along with links to source code relevant to it.

@hongkailiu hongkailiu deleted the fix_os_test branch June 12, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants