templates/installer: copy artifacts after install#1630
templates/installer: copy artifacts after install#1630openshift-merge-robot merged 1 commit intoopenshift:masterfrom crawford:installer-tfvars
Conversation
openshift-ci-robot
added
the
size/XS
|
/cc @stevekuznetsov |
The installer is moving the generation of terraform.tfvars from "init" to "install".
| tectonic init --config=inputs.yaml | ||
| mv -f ${NAME}/* /tmp/cluster/ | ||
| cp config.yaml internal.yaml terraform.tfvars /tmp/artifacts/installer/ | ||
| cp config.yaml internal.yaml /tmp/artifacts/installer/ |
There was a problem hiding this comment.
It would be nice to get these even if install fails. Maybe put it in an EXIT trap like this to copy this asset out regardless of install success?
There was a problem hiding this comment.
I'd rather we keep this dead simple since it's holding up some PRs that have to go in. Once those merge, I'm going to come back and update all of this to work with the new installer.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@crawford: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
The installer is moving the generation of terraform.tfvars from "init"
to "install".