Skip to content

Add openshift/driver-toolkit to the openshift-ci#16681

Merged
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
dagrayvid:add_driver_toolkit
Mar 16, 2021
Merged

Add openshift/driver-toolkit to the openshift-ci#16681
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
dagrayvid:add_driver_toolkit

Conversation

@dagrayvid
Copy link
Contributor

@dagrayvid dagrayvid commented Mar 10, 2021

Add openshift/driver-toolkit to the OpenShift CI. driver-toolkit is a container to be used as a base for creating driver-containers for OpenShift. For more information see SRO and this enhancement. We don't want to require any tests/branch-protection (at least for now) but want automated release branching / tide.

Signed-off-by: David Gray dagray@redhat.com

@dagrayvid
Copy link
Contributor Author

dagrayvid commented Mar 10, 2021

/cc @ArangoGutierrez
/cc @zvonkok

ArangoGutierrez
ArangoGutierrez suggested changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is just a driver-container I don't see why running the full aws-e2e suite. at least not until SRO becomes CVO. we need to find a better way to run a quick and dirty test over the repo that is not the full e2e-aws suite (which is also slow)

ci-operator/config/openshift/driver-toolkit/openshift-driver-toolkit-master.yaml Outdated
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez Mar 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

ci-operator/config/openshift/driver-toolkit/openshift-driver-toolkit-release-4.6.yaml Outdated
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez Mar 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

ci-operator/config/openshift/driver-toolkit/openshift-driver-toolkit-release-4.7.yaml Outdated
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez Mar 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

@dagrayvid dagrayvid force-pushed the add_driver_toolkit branch from f350be1 to be0e97b Compare March 10, 2021 17:21
@zvonkok
Copy link

zvonkok commented Mar 10, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2021
@dagrayvid
Copy link
Contributor Author

dagrayvid commented Mar 10, 2021

/retest

2 similar comments
@dagrayvid
Copy link
Contributor Author

dagrayvid commented Mar 10, 2021

/retest

@zvonkok
Copy link

zvonkok commented Mar 11, 2021

/retest

@dagrayvid dagrayvid force-pushed the add_driver_toolkit branch from be0e97b to 676e77a Compare March 11, 2021 12:29
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2021
@dagrayvid
Copy link
Contributor Author

dagrayvid commented Mar 11, 2021

/retest

2 similar comments
@dagrayvid
Copy link
Contributor Author

dagrayvid commented Mar 11, 2021

/retest

@dagrayvid
Copy link
Contributor Author

dagrayvid commented Mar 11, 2021

/retest

@zvonkok
Copy link

zvonkok commented Mar 11, 2021

/lgtm

@zvonkok
Copy link

zvonkok commented Mar 11, 2021

/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2021
@ArangoGutierrez
Copy link
Contributor

ArangoGutierrez commented Mar 11, 2021

/assign @petr-muller

@ArangoGutierrez
Copy link
Contributor

ArangoGutierrez commented Mar 16, 2021

PING @petr-muller

@dagrayvid dagrayvid force-pushed the add_driver_toolkit branch from 676e77a to 94042e5 Compare March 16, 2021 13:25
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2021 •
edited
Loading

@dagrayvid: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/driver-toolkit/master/e2e-aws f350be1aedd22b47b0fc5ed307b276df97257d62 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ArangoGutierrez
ArangoGutierrez approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2021
@dagrayvid
Copy link
Contributor Author

dagrayvid commented Mar 16, 2021

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, dagrayvid, petr-muller, zvonkok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2021
@openshift-merge-robot openshift-merge-robot merged commit 6c22374 into openshift:master Mar 16, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 16, 2021

@dagrayvid: Updated the following 13 configmaps:

  • job-config-4.6 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-driver-toolkit-release-4.6-presubmits.yaml using file ci-operator/jobs/openshift/driver-toolkit/openshift-driver-toolkit-release-4.6-presubmits.yaml
  • job-config-4.7 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-driver-toolkit-release-4.7-presubmits.yaml using file ci-operator/jobs/openshift/driver-toolkit/openshift-driver-toolkit-release-4.7-presubmits.yaml
  • config configmap in namespace ci at cluster api.ci using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-driver-toolkit-master.yaml using file ci-operator/config/openshift/driver-toolkit/openshift-driver-toolkit-master.yaml
  • ci-operator-4.6-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-driver-toolkit-release-4.6.yaml using file ci-operator/config/openshift/driver-toolkit/openshift-driver-toolkit-release-4.6.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-driver-toolkit-master-presubmits.yaml using file ci-operator/jobs/openshift/driver-toolkit/openshift-driver-toolkit-master-presubmits.yaml
  • plugins configmap in namespace ci at cluster api.ci using the following files:
    • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml
  • job-config-4.7 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-driver-toolkit-release-4.7-presubmits.yaml using file ci-operator/jobs/openshift/driver-toolkit/openshift-driver-toolkit-release-4.7-presubmits.yaml
  • ci-operator-4.7-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-driver-toolkit-release-4.7.yaml using file ci-operator/config/openshift/driver-toolkit/openshift-driver-toolkit-release-4.7.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-driver-toolkit-master-presubmits.yaml using file ci-operator/jobs/openshift/driver-toolkit/openshift-driver-toolkit-master-presubmits.yaml
  • job-config-4.6 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-driver-toolkit-release-4.6-presubmits.yaml using file ci-operator/jobs/openshift/driver-toolkit/openshift-driver-toolkit-release-4.6-presubmits.yaml
Details

In response to this:

Add openshift/driver-toolkit to the OpenShift CI. driver-toolkit is a container to be used as a base for creating driver-containers for OpenShift. For more information see SRO and this enhancement. We don't want to require any tests/branch-protection (at least for now) but want automated release branching / tide.

Signed-off-by: David Gray dagray@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zvonkok zvonkok Awaiting requested review from zvonkok

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

2 more reviewers

@petr-muller petr-muller petr-muller approved these changes

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@petr-muller petr-muller

@zvonkok zvonkok

@ArangoGutierrez ArangoGutierrez

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dagrayvid @zvonkok @ArangoGutierrez @openshift-ci-robot @petr-muller @openshift-merge-robot