Skip to content

machine-config-operator: add gcp-op test for single-node#17357

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
sinnykumari:master
Apr 14, 2021
Merged

machine-config-operator: add gcp-op test for single-node#17357
openshift-merge-robot merged 1 commit into
openshift:masterfrom
sinnykumari:master

Conversation

@sinnykumari
Copy link
Copy Markdown
Contributor

@sinnykumari sinnykumari commented Mar 31, 2021

No description provided.

@sinnykumari
Copy link
Copy Markdown
Contributor Author

sinnykumari commented Mar 31, 2021

Needs #17139
/hold

@sinnykumari
Copy link
Copy Markdown
Contributor Author

sinnykumari commented Mar 31, 2021

/cc @Omeramsc

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2021
kikisdeliveryservice
kikisdeliveryservice reviewed Mar 31, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we need to explicitly also update the 4.8/4.9.yamls as well

@sinnykumari sinnykumari mentioned this pull request Mar 31, 2021
Merged
@sinnykumari
Copy link
Copy Markdown
Contributor Author

sinnykumari commented Mar 31, 2021

yeah, was thinking of doing it in another PR once we know it works for master

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

kikisdeliveryservice commented Mar 31, 2021

hmm something is wrong with the yaml:

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/17357/pull-ci-openshift-release-yamllint/1377293986229653504

@sinnykumari
Copy link
Copy Markdown
Contributor Author

sinnykumari commented Mar 31, 2021

yeah, fixed it.

kikisdeliveryservice
kikisdeliveryservice approved these changes Apr 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove hold whenever you are ready.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 12, 2021

@sinnykumari: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2021
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2021
@sinnykumari
Copy link
Copy Markdown
Contributor Author

sinnykumari commented Apr 13, 2021

Dependent PR #17139 has been merged.
/hold cancel
Rebased PR to fix merge conflict

@openshift-ci-robot openshift-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 13, 2021
@sinnykumari
Copy link
Copy Markdown
Contributor Author

sinnykumari commented Apr 13, 2021

/test pj-rehearse

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 13, 2021

@sinnykumari: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/machine-config-operator/master/e2e-gcp-op-single-node 98b1222 link /test pj-rehearse
ci/prow/pj-rehearse 98b1222 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sinnykumari
Copy link
Copy Markdown
Contributor Author

sinnykumari commented Apr 14, 2021 •
edited
Loading

When a new job gets added it usually fails(don't know why) but this is the pattern I have observed in already merged PRs in this repo like #13435 , #9607

kikisdeliveryservice
kikisdeliveryservice approved these changes Apr 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @sinnykumari

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2021
@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

kikisdeliveryservice commented Apr 14, 2021

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 89af25b into openshift:master Apr 14, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 14, 2021

@sinnykumari: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Omeramsc Omeramsc Awaiting requested review from Omeramsc

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

1 more reviewer

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kikisdeliveryservice kikisdeliveryservice

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sinnykumari @kikisdeliveryservice @openshift-ci-robot @openshift-merge-robot