Skip to content

Add URL to openshift/library failure notice#20844

Merged
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
adambkaplan:fix-library-import-prow
Aug 3, 2021
Merged

Add URL to openshift/library failure notice#20844
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
adambkaplan:fix-library-import-prow

Conversation

@adambkaplan
Copy link
Copy Markdown
Contributor

@adambkaplan adambkaplan commented Aug 3, 2021

  • Add the URL to the job if the import for openshift/library fails.
  • Send notification to #forum-app-services. This team is taking over
    maintenance of the Samples Operator.

@adambkaplan
Copy link
Copy Markdown
Contributor Author

adambkaplan commented Aug 3, 2021

/cc @dperaza4dustbit

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2021
dperaza4dustbit
dperaza4dustbit reviewed Aug 3, 2021
View reviewed changes
ci-operator/jobs/openshift/library/openshift-library-master-periodics.yaml Outdated
Copy link
Copy Markdown
Contributor

@dperaza4dustbit dperaza4dustbit Aug 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh OK, send that to forum-appsvc-notify

Copy link
Copy Markdown
Contributor Author

@adambkaplan adambkaplan Aug 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. @dperaza4dustbit I believe you have the ability to lgtm.

@adambkaplan
Add URL to openshift/library failure notice
3b0cfa4 
- Add the URL to the job if the import for openshift/library fails.
- Send notification to #forum-app-services. This team is taking over
  maintenance of the Samples Operator.
@adambkaplan adambkaplan force-pushed the fix-library-import-prow branch from 9182a7a to 3b0cfa4 Compare August 3, 2021 14:35
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Aug 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, dperaza4dustbit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit e3f1254 into openshift:master Aug 3, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Aug 3, 2021

@adambkaplan: Updated the job-config-master configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-library-master-periodics.yaml using file ci-operator/jobs/openshift/library/openshift-library-master-periodics.yaml
Details

In response to this:

  • Add the URL to the job if the import for openshift/library fails.
  • Send notification to #forum-app-services. This team is taking over
    maintenance of the Samples Operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@gabemontero gabemontero Awaiting requested review from gabemontero

1 more reviewer

@dperaza4dustbit dperaza4dustbit dperaza4dustbit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dperaza4dustbit dperaza4dustbit

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adambkaplan @dperaza4dustbit