Skip to content

Comments

Bug 2024617: Fix vSphere CSI jobs on 4.10#23769

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
jsafrane:fix-vsphere
Nov 19, 2021
Merged

Bug 2024617: Fix vSphere CSI jobs on 4.10#23769
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
jsafrane:fix-vsphere

Conversation

@jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Nov 18, 2021

In 4.10, the vSphere CSI driver is installed by default, there is no need to enable TechPreviewNoUpgrade. Enabling tech preview enables CSI migration, which we know is broken right now.

Therefore:

  • Create a separate Ci workflow openshift-e2e-vsphere-csi-techpreview that enables TechPreviewNoUpgrade and use it in 4.8-4.9 CI jobs
  • Rework openshift-e2e-vsphere-csi not to enable it and use it in 4.10 jobs.

@openshift/storage

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2021

@jsafrane: This pull request references Bugzilla bug 2024617, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

Details

In response to this:

Bug 2024617: Fix vSphere CSI jobs on 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 18, 2021
@openshift-ci openshift-ci bot requested review from bertinatto and dobsonj November 18, 2021 14:30
@jsafrane
Copy link
Contributor Author

jsafrane commented Nov 18, 2021

/retest
4.10 installation faked

bertinatto
bertinatto reviewed Nov 18, 2021
View reviewed changes
ci-operator/step-registry/openshift/e2e/vsphere/csi/techpreview/OWNERS Outdated
Copy link
Member

@bertinatto bertinatto Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to replace this with @dobsonj

Copy link
Contributor Author

@jsafrane jsafrane Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

bertinatto
bertinatto reviewed Nov 18, 2021
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit about owners

bertinatto
bertinatto reviewed Nov 19, 2021
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for removing TechPreviewNoUpgrade from the CSI job, I missed that.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2021
@stbenjam
Copy link
Member

stbenjam commented Nov 19, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7188d7b into openshift:master Nov 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2021

@jsafrane: All pull requests linked via external trackers have merged:

Bugzilla bug 2024617 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2024617: Fix vSphere CSI jobs on 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2021

@jsafrane: Updated the following 4 configmaps:

  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/vsphere/csi/OWNERS
    • key openshift-e2e-vsphere-csi-workflow.metadata.json using file ci-operator/step-registry/openshift/e2e/vsphere/csi/openshift-e2e-vsphere-csi-workflow.metadata.json
    • key openshift-e2e-vsphere-csi-workflow.yaml using file ci-operator/step-registry/openshift/e2e/vsphere/csi/openshift-e2e-vsphere-csi-workflow.yaml
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/vsphere/csi/techpreview/OWNERS
    • key openshift-e2e-vsphere-csi-techpreview-workflow.metadata.json using file ci-operator/step-registry/openshift/e2e/vsphere/csi/techpreview/openshift-e2e-vsphere-csi-techpreview-workflow.metadata.json
    • key openshift-e2e-vsphere-csi-techpreview-workflow.yaml using file ci-operator/step-registry/openshift/e2e/vsphere/csi/techpreview/openshift-e2e-vsphere-csi-techpreview-workflow.yaml
  • ci-operator-4.8-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-storage-operator-release-4.8.yaml using file ci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-release-4.8.yaml
    • key openshift-vmware-vsphere-csi-driver-operator-release-4.8.yaml using file ci-operator/config/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-release-4.8.yaml
    • key openshift-vmware-vsphere-csi-driver-release-4.8.yaml using file ci-operator/config/openshift/vmware-vsphere-csi-driver/openshift-vmware-vsphere-csi-driver-release-4.8.yaml
  • ci-operator-4.9-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-storage-operator-release-4.9.yaml using file ci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-release-4.9.yaml
    • key openshift-vmware-vsphere-csi-driver-operator-release-4.9.yaml using file ci-operator/config/openshift/vmware-vsphere-csi-driver-operator/openshift-vmware-vsphere-csi-driver-operator-release-4.9.yaml
    • key openshift-vmware-vsphere-csi-driver-release-4.9.yaml using file ci-operator/config/openshift/vmware-vsphere-csi-driver/openshift-vmware-vsphere-csi-driver-release-4.9.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master__nightly-4.8.yaml using file ci-operator/config/openshift/release/openshift-release-master__nightly-4.8.yaml
    • key openshift-release-master__nightly-4.9.yaml using file ci-operator/config/openshift/release/openshift-release-master__nightly-4.9.yaml
Details

In response to this:

In 4.10, the vSphere CSI driver is installed by default, there is no need to enable TechPreviewNoUpgrade. Enabling tech preview enables CSI migration, which we know is broken right now.

Therefore:

  • Create a separate Ci workflow openshift-e2e-vsphere-csi-techpreview that enables TechPreviewNoUpgrade and use it in 4.8-4.9 CI jobs
  • Rework openshift-e2e-vsphere-csi not to enable it and use it in 4.10 jobs.

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dobsonj dobsonj Awaiting requested review from dobsonj

1 more reviewer

@bertinatto bertinatto bertinatto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bertinatto bertinatto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jsafrane @stbenjam @bertinatto @openshift-merge-robot