-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add new repository - openshift/cluster-api-provider-kubevirt #24575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new repository - openshift/cluster-api-provider-kubevirt #24575
Conversation
41f0023 to
6bc973e
Compare
| cluster_groups: | ||
| build_farm_ci: | ||
| clusters: | ||
| - app.ci | ||
| - build01 | ||
| - build02 | ||
| - build03 | ||
| - build04 | ||
| - vsphere | ||
| namespaces: | ||
| - ci | ||
| build_farm_ocp: | ||
| clusters: | ||
| - app.ci | ||
| - build01 | ||
| - build02 | ||
| - build03 | ||
| - build04 | ||
| - vsphere | ||
| namespaces: | ||
| - ocp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes in this _plugins.yaml file look a bit suspicious considering we're just trying to enable ci on the openshift/cluster-api-provider-kubevirt repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, also noticed to this change, created by the auto generator (make new-repo)
I removed this change
| - as: func-tests | ||
| commands: go mod tidy && go mod vendor && make functest | ||
| container: | ||
| from: bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we'll be successful in running the functional tests like this. For now i think we can just execute the unit tests until we get a func test suite that can execute on openshift ci.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
I removed the func tests, The func tests will be added later
…w-repo") Signed-off-by: Nir Argaman <nargaman@redhat.com>
6bc973e to
516d8e8
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirarg, nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@nirarg: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@nirarg: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is done by running "make new-repo"
Adding the following repository: https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt