-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[vsphere] define mirror registry to be used for selected 4.6 e2e tests #25007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-robot
merged 1 commit into
openshift:master
from
rvanderp3:define-e2e-mirror-46-vsphere
Jan 10, 2022
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
ci-operator/step-registry/openshift/e2e/vsphere/release46/OWNERS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| approvers: | ||
| - bostrt | ||
| - jcpowermac | ||
| - rvanderp3 | ||
| - patrickdillon |
11 changes: 11 additions & 0 deletions
11
...ry/openshift/e2e/vsphere/release46/openshift-e2e-vsphere-release46-workflow.metadata.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "path": "openshift/e2e/vsphere/release46/openshift-e2e-vsphere-release46-workflow.yaml", | ||
| "owners": { | ||
| "approvers": [ | ||
| "bostrt", | ||
| "jcpowermac", | ||
| "rvanderp3", | ||
| "patrickdillon" | ||
| ] | ||
| } | ||
| } |
16 changes: 16 additions & 0 deletions
16
...ep-registry/openshift/e2e/vsphere/release46/openshift-e2e-vsphere-release46-workflow.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| workflow: | ||
| as: openshift-e2e-vsphere-release46 | ||
| steps: | ||
| pre: | ||
| - chain: ipi-vsphere-pre | ||
| test: | ||
| - ref: openshift-e2e-test | ||
| post: | ||
| - chain: gather-core-dump | ||
| - chain: ipi-vsphere-post | ||
| env: | ||
| TEST_IMAGE_MIRROR_REGISTRY: e2e-cache.vmc-ci.devcluster.openshift.com:5000 | ||
| documentation: |- | ||
| E2E test workflow for vSphere 4.6 CI jobs. This workflow sets an environment variable which informs | ||
| targetting tests of where to pull their images to avoid docker.io rate limiting. | ||
|
|
5 changes: 5 additions & 0 deletions
5
ci-operator/step-registry/openshift/e2e/vsphere/upi/release46/OWNERS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| approvers: | ||
| - bostrt | ||
| - jcpowermac | ||
| - rvanderp3 | ||
| - patrickdillon |
11 changes: 11 additions & 0 deletions
11
...hift/e2e/vsphere/upi/release46/openshift-e2e-vsphere-upi-release46-workflow.metadata.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "path": "openshift/e2e/vsphere/upi/release46/openshift-e2e-vsphere-upi-release46-workflow.yaml", | ||
| "owners": { | ||
| "approvers": [ | ||
| "bostrt", | ||
| "jcpowermac", | ||
| "rvanderp3", | ||
| "patrickdillon" | ||
| ] | ||
| } | ||
| } |
15 changes: 15 additions & 0 deletions
15
...try/openshift/e2e/vsphere/upi/release46/openshift-e2e-vsphere-upi-release46-workflow.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| workflow: | ||
| as: openshift-e2e-vsphere-upi-release46 | ||
| steps: | ||
| pre: | ||
| - chain: upi-vsphere-pre | ||
| test: | ||
| - ref: openshift-e2e-test | ||
| post: | ||
| - chain: upi-vsphere-post | ||
| env: | ||
| TEST_IMAGE_MIRROR_REGISTRY: e2e-cache.vmc-ci.devcluster.openshift.com:5000 | ||
| documentation: |- | ||
| E2E test workflow for vSphere 4.6 CI jobs. This workflow sets an environment variable which informs | ||
| targetting tests of where to pull their images to avoid docker.io rate limiting. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow is incredibly useful for OKD jobs, which uses a lot of docker.io images. Lets rename this to
openshift-e2e-vsphere-upi-pullthroughor similar?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for specifically calling out release-4.6 in the name is due to the fact that this configuration is not necessary in 4.7 and later as the targeted tests in openshift-tests already pull from other sources. The bulk of the tests which failed due to rate limiting are fixed by configuring a mirror in crio.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see, okay