Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Jan 24, 2022

These are descended from f0d68be (#13384), where they were intended to make it easy for folks to evaluate in-flight CVO pull requests vs. assisted-installer CI.

However, with the recent /payload ... test support, we can maintain the job configuration for the release-controller periodics, and run them as needed on component pull requests, without having to maintain per-component presubmit configuration. This commit drops the per-component presubmit configuration to reduce future maintenance work.

…-assisted presubmits

These are descended from f0d68be (Add e2e-metal-assisted to
installer and cluster-version-operator, 2020-11-04, openshift#13384), where
they were intended to make it easy for folks to evaluate in-flight CVO
pull requests vs. assisted-installer CI.

However, with the recent '/payload ...' test support [1], we can
maintain the job configuration for the release-controller periodics,
and run them as needed on component pull requests, without having to
maintain per-component presubmit configuration.  This commit drops the
per-component presubmit configuration to reduce future maintenance
work.

[1]: https://docs.ci.openshift.org/docs/release-oversight/payload-testing/
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2022
@openshift-ci openshift-ci bot requested review from jottofar and vrutkovs January 24, 2022 23:04
@lranjbar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lranjbar, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d1db786 into openshift:master Jan 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

@wking: Updated the following 12 configmaps:

  • ci-operator-4.11-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-version-operator-release-4.11.yaml using file ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-release-4.11.yaml
  • ci-operator-4.8-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-version-operator-release-4.8.yaml using file ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-release-4.8.yaml
  • ci-operator-4.9-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-version-operator-release-4.9.yaml using file ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-release-4.9.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-version-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-version-operator/openshift-cluster-version-operator-master-presubmits.yaml
  • job-config-4.11 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-version-operator-release-4.11-presubmits.yaml using file ci-operator/jobs/openshift/cluster-version-operator/openshift-cluster-version-operator-release-4.11-presubmits.yaml
  • job-config-4.8 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-version-operator-release-4.8-presubmits.yaml using file ci-operator/jobs/openshift/cluster-version-operator/openshift-cluster-version-operator-release-4.8-presubmits.yaml
  • job-config-4.9 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-version-operator-release-4.9-presubmits.yaml using file ci-operator/jobs/openshift/cluster-version-operator/openshift-cluster-version-operator-release-4.9-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-version-operator-master.yaml using file ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-master.yaml
  • ci-operator-4.7-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-version-operator-release-4.7.yaml using file ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-release-4.7.yaml
  • job-config-4.10 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-version-operator-release-4.10-presubmits.yaml using file ci-operator/jobs/openshift/cluster-version-operator/openshift-cluster-version-operator-release-4.10-presubmits.yaml
  • job-config-4.7 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-version-operator-release-4.7-presubmits.yaml using file ci-operator/jobs/openshift/cluster-version-operator/openshift-cluster-version-operator-release-4.7-presubmits.yaml
  • ci-operator-4.10-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-version-operator-release-4.10.yaml using file ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-release-4.10.yaml
Details

In response to this:

These are descended from f0d68be (#13384), where they were intended to make it easy for folks to evaluate in-flight CVO pull requests vs. assisted-installer CI.

However, with the recent /payload ... test support, we can maintain the job configuration for the release-controller periodics, and run them as needed on component pull requests, without having to maintain per-component presubmit configuration. This commit drops the per-component presubmit configuration to reduce future maintenance work.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking wking deleted the drop-assisted-installer-presubmits-from-cluster-version branch January 24, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants