Skip to content

Merge shift-week-better-retester to the master branch: Merging config files in ci-tools, Update deployment file#27818

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
nesty156:DPTP-2826
Apr 20, 2022
Merged

Merge shift-week-better-retester to the master branch: Merging config files in ci-tools, Update deployment file#27818
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
nesty156:DPTP-2826

Conversation

@nesty156
Copy link
Copy Markdown

@nesty156 nesty156 commented Apr 13, 2022

  • I merged ci-tools configs shift-week-better-retester to master.
  • Changed names: better-retester to retester.
  • Changed filename of retester deployment.

DPTP-2826

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 13, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 13, 2022

Hi @nesty156. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hongkailiu
hongkailiu reviewed Apr 13, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@hongkailiu hongkailiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to clean up the renamed objects after merge.
Can we list those commands? such as

$ oc delete deployment better-retester -n ci

Otherwise, LGTM.

ci-operator/config/openshift/ci-tools/openshift-ci-tools-master.yaml Outdated
Copy link
Copy Markdown
Member

@hongkailiu hongkailiu Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

We need to merge the source code first.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2022
@petr-muller
Copy link
Copy Markdown
Member

petr-muller commented Apr 14, 2022

/ok-to-test

Can't hurt

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 14, 2022
@hongkailiu
Copy link
Copy Markdown
Member

hongkailiu commented Apr 20, 2022

/retest

@hongkailiu
Copy link
Copy Markdown
Member

hongkailiu commented Apr 20, 2022

@nesty156

We need to fix the presubmit.
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/27818/pull-ci-openshift-release-master-generated-config/1516604254754705408#1:build-log.txt%3A9

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 20, 2022
Vojtěch Kronika added 2 commits April 20, 2022 15:25
Merging config files in ci-tools, Changing name and tag for retester …
0985e02 
…deployment.

Merged openshift-ci-tools-shift-week-retester.yaml to openshift-ci-tools-master.yaml
Deleted openshift-ci-tools-shift-week-retester.yaml
Changed name of deployment better-retester.yaml to retester.yaml
In deployment changed all names better-retester to retester and shift-week tag to latest
run make jobs
3580ed5
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 20, 2022
@hongkailiu
Copy link
Copy Markdown
Member

hongkailiu commented Apr 20, 2022

INFO[2022-04-20T14:15:55Z] Build retester succeeded after 24m5s

/lgtm

@hongkailiu
Copy link
Copy Markdown
Member

hongkailiu commented Apr 20, 2022

@nesty156

Feel free to cancel the hold when you are ready to watch the rolling.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, nesty156

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2022
@nesty156
Copy link
Copy Markdown
Author

nesty156 commented Apr 20, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2022
@openshift-merge-robot openshift-merge-robot merged commit e29019d into openshift:master Apr 20, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 20, 2022

@nesty156: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-ci-tools-master.yaml using file ci-operator/config/openshift/ci-tools/openshift-ci-tools-master.yaml
  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-ci-tools-shift-week-better-retester.yaml using file ``
  • job-config-misc configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-ci-tools-shift-week-better-retester-postsubmits.yaml using file ``
    • key openshift-ci-tools-shift-week-better-retester-presubmits.yaml using file ``
Details

In response to this:

  • I merged ci-tools configs shift-week-better-retester to master.
  • Changed names: better-retester to retester.
  • Changed filename of retester deployment.

DPTP-2826

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 20, 2022

@nesty156: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hongkailiu
Copy link
Copy Markdown
Member

hongkailiu commented Apr 20, 2022 •
edited
Loading 

$ oc delete deployment -n ci better-retester --as system:admin
deployment.apps "better-retester" deleted
$ oc delete pvc -n ci better-retester --as system:admin
persistentvolumeclaim "better-retester" deleted

$ oc get pod -n ci | grep retester
retester-69fdb9bdbc-nbgmc                                                   1/1     Running                  0               176m

bbguimaraes added a commit to bbguimaraes/release that referenced this pull request Jun 17, 2022
@bbguimaraes
ci-tools: remove retester branch configuration
2480bf7 
Removed in openshift#27818.
@bbguimaraes bbguimaraes mentioned this pull request Jun 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danilo-gemoli danilo-gemoli Awaiting requested review from danilo-gemoli

@petr-muller petr-muller Awaiting requested review from petr-muller

1 more reviewer

@hongkailiu hongkailiu hongkailiu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@hongkailiu hongkailiu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nesty156 @petr-muller @hongkailiu @openshift-merge-robot