Skip to content

run cosa build in the test stages to take advantage of KVM#29187

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cheesesashimi:zzlotnik/fix-rhcos-timeouts
Jun 6, 2022
Merged

run cosa build in the test stages to take advantage of KVM#29187
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cheesesashimi:zzlotnik/fix-rhcos-timeouts

Conversation

@cheesesashimi
Copy link
Copy Markdown
Member

Because the image build for cosa-build takes so long, we're running into
timeouts by the time the test stages are run. Instead, we should also run cosa
build concurrently in the test stages which are able to take advantage of KVM
and reduce the overall time of the build / test run.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 6, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cheesesashimi
Copy link
Copy Markdown
Member Author

/test pj-rehearse

@openshift-ci openshift-ci Bot requested review from gursewak1997 and ravanelli June 6, 2022 18:46
@cheesesashimi cheesesashimi force-pushed the zzlotnik/fix-rhcos-timeouts branch from 8ded297 to ad8c3a2 Compare June 6, 2022 18:59
@cheesesashimi
Copy link
Copy Markdown
Member Author

/test pj-rehearse

@miabbott
Copy link
Copy Markdown
Member

miabbott commented Jun 6, 2022

Tests are failing with qemu-img: /var/tmp/mantle-qemu4189136715/disk3207901125: Image creation needs a size parameter

I think this is usually an indication that the qcow2 image can't be found when cosa kola run tries to create a VM

@cheesesashimi cheesesashimi marked this pull request as ready for review June 6, 2022 20:33
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2022
@openshift-ci openshift-ci Bot requested review from aaradhak and mike-nguyen June 6, 2022 20:37
@cheesesashimi
Copy link
Copy Markdown
Member Author

/assign @miabbott

@miabbott
Copy link
Copy Markdown
Member

miabbott commented Jun 6, 2022

Just thinking through the steps out loud...

build-test-qemu-img is just a cosa container + a golang builder container with the CoreOS Layering test binary built + copied into the resulting container image.

That image is then used to call out to prow-build.sh which is doing the usual cosa fetch and cosa build operations before running whatever test is asked.

Should just work ™️ ! (test-qemu-metal might get dicey building the extra artifacts, but let's see what happens)

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, miabbott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2022
@openshift-merge-robot openshift-merge-robot merged commit 707a7f4 into openshift:master Jun 6, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 6, 2022

@cheesesashimi: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-os-master.yaml using file ci-operator/config/openshift/os/openshift-os-master.yaml
  • key openshift-os-master__periodic.yaml using file ci-operator/config/openshift/os/openshift-os-master__periodic.yaml
Details

In response to this:

Because the image build for cosa-build takes so long, we're running into
timeouts by the time the test stages are run. Instead, we should also run cosa
build concurrently in the test stages which are able to take advantage of KVM
and reduce the overall time of the build / test run.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 6, 2022

@cheesesashimi: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants