Skip to content

openshift/os: Copy all cluster jobs from MCO#29228

Closed
cgwalters wants to merge 1 commit intoopenshift:masterfrom
cgwalters:os-test-e2es
Closed

openshift/os: Copy all cluster jobs from MCO#29228
cgwalters wants to merge 1 commit intoopenshift:masterfrom
cgwalters:os-test-e2es

Conversation

@cgwalters
Copy link
Copy Markdown
Member

Recently a lot of useful work landed in the CI for openshift/os,
in particular bits which actually launch a cluster, which closes
a huge gap.

However, the (previously named) test-in-cluster was just testing
that a cluster installs in GCP, and then we run a custom test
do do a build+rebase in cluster.

While that's a useful test, we actually want to be able to run
all the regular openshift e2e tests as well, for things like RHEL
rebases.

Rename test-in-clustertest-boot-derived-image for clarity,
and while we're here make it optional: true because it's actually
broken right now since coreos/layering-examples#21
landed - we need to change the test to synthesize a rhel.repo.

Recently a lot of useful work landed in the CI for openshift/os,
in particular bits which actually launch a cluster, which closes
a huge gap.

However, the (previously named) `test-in-cluster` was just testing
that a cluster installs in GCP, and then we run a custom test
do do a build+rebase in cluster.

While that's a useful test, we actually want to be able to run
all the regular openshift e2e tests as well, for things like RHEL
rebases.

Rename `test-in-cluster` → `test-boot-derived-image` for clarity,
and while we're here make it `optional: true` because it's actually
broken right now since coreos/layering-examples#21
landed - we need to change the test to synthesize a `rhel.repo`.
@openshift-ci openshift-ci Bot requested review from HuijingHei and prestist June 7, 2022 17:03
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2022
@cgwalters
Copy link
Copy Markdown
Member Author

OK actually I think these jobs need to inherit from the built image.

@cgwalters cgwalters marked this pull request as draft June 7, 2022 17:23
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2022
@cgwalters
Copy link
Copy Markdown
Member Author

OK yeah to make this work today, we need to also build and push the legacy format container to actually test things.

Or...we hold this until we've finished a hard switch to the new format.

@cheesesashimi
Copy link
Copy Markdown
Member

OK actually I think these jobs need to inherit from the built image.

They'll need to. The big issue I foresee is that building the RHCOS image the way that we do takes a very long time. So adding that and the openshift-e2e suites would result in a very long-running test. And unfortunately, I can't think of an alternative that wouldn't add a substantial amount of additional complexity.

@HuijingHei
Copy link
Copy Markdown
Contributor

The long running test would be a problem, how about just trigger the e2e suite only by manual command like /test openshift-e2e, instead of by default. If we have rebase 9.x PR in the future, can trigger the e2e test manually

@cheesesashimi
Copy link
Copy Markdown
Member

The long running test would be a problem, how about just trigger the e2e suite only by manual command like /test openshift-e2e, instead of by default.

That sounds reasonable to me.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 10, 2022

@cgwalters: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 1, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 1, 2022

@cgwalters: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/release-controller-config 1bb7fd2 link true /test release-controller-config
ci/prow/jira-lifecycle-config 1bb7fd2 link true /test jira-lifecycle-config
ci/prow/pr-reminder-config 1bb7fd2 link true /test pr-reminder-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 17, 2022
@openshift-bot
Copy link
Copy Markdown
Contributor

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci Bot closed this Sep 1, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 1, 2022

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants