Skip to content

openshift/os: Use coreos-assembler:4.11 for 4.11#29588

Closed
HuijingHei wants to merge 1 commit intoopenshift:masterfrom
HuijingHei:openshift-os-cosa-4.11
Closed

openshift/os: Use coreos-assembler:4.11 for 4.11#29588
HuijingHei wants to merge 1 commit intoopenshift:masterfrom
HuijingHei:openshift-os-cosa-4.11

Conversation

@HuijingHei
Copy link
Copy Markdown
Contributor

@HuijingHei HuijingHei commented Jun 17, 2022

To make the openshift branching 4.11

@openshift-ci openshift-ci Bot requested review from jlebon and sohankunkerkar June 17, 2022 01:40
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2022
@HuijingHei HuijingHei force-pushed the openshift-os-cosa-4.11 branch 2 times, most recently from 41a66c2 to bbc5552 Compare June 28, 2022 08:38
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuijingHei, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travier
Copy link
Copy Markdown
Member

travier commented Jun 28, 2022

/retest

@HuijingHei
Copy link
Copy Markdown
Contributor Author

HuijingHei commented Jun 28, 2022

The error seems need to remove fedora and ocp_builder_rhel-8-golang-1.17-openshift-4.11 in base_images, do we need them?

time="2022-06-28T08:40:24Z" level=error msg="Failed to load CI Operator configuration" error="failed to load ci-operator config (error unmarshaling JSON: json: cannot unmarshal number into Go struct field ImageStreamTagReference.base_images.tag of type string)" source-file=ci-operator/config/openshift/os/openshift-os-release-4.11.yaml

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 28, 2022

/retest-required

Remaining retests: 2 against base HEAD 0818448 and 8 for PR HEAD bbc55522879756dceef90dc4c87327bdf9dfebaf in total

@travier
Copy link
Copy Markdown
Member

travier commented Jun 28, 2022

/hold
While we figure out the issue

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2022
@miabbott
Copy link
Copy Markdown
Member

miabbott commented Jun 28, 2022

It could be that fedora:36 and ocp:rhel-8-golang-1.17-openshift-4.11 don't exist as ImageStreamTags?

@HuijingHei
openshift/os: Use coreos-assembler:4.11 for 4.11
2db6ea3 
To make the openshift branching 4.11
@HuijingHei HuijingHei force-pushed the openshift-os-cosa-4.11 branch from bbc5552 to 2db6ea3 Compare June 29, 2022 03:01
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 29, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 29, 2022

@HuijingHei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-operator-registry 2db6ea3 link true /test ci-operator-registry
ci/prow/ci-operator-config 2db6ea3 link true /test ci-operator-config
ci/prow/openshift-image-mirror-mappings 2db6ea3 link true /test openshift-image-mirror-mappings
ci/prow/pj-rehearse 2db6ea3 link false /test pj-rehearse
ci/prow/generated-config 2db6ea3 link true /test generated-config
ci/prow/correctly-sharded-config 2db6ea3 link true /test correctly-sharded-config
ci/prow/ci-operator-config-metadata 2db6ea3 link true /test ci-operator-config-metadata

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@HuijingHei
Copy link
Copy Markdown
Contributor Author

HuijingHei commented Jun 29, 2022

It could be that fedora:36 and ocp:rhel-8-golang-1.17-openshift-4.11 don't exist as ImageStreamTags?

No idea where to check, any suggestions?

@HuijingHei
Copy link
Copy Markdown
Contributor Author

HuijingHei commented Jun 29, 2022

duplicate to #29949

@HuijingHei HuijingHei closed this Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlebon jlebon Awaiting requested review from jlebon

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

1 more reviewer

@travier travier travier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@travier travier

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HuijingHei @travier @openshift-ci-robot @miabbott