Skip to content

WINC-520: Use Existing OpenShift Releases for CI jobs#31811

Closed
jrvaldes wants to merge 1 commit into
openshift:masterfrom
jrvaldes:WINC-520-test-releases
Closed

WINC-520: Use Existing OpenShift Releases for CI jobs#31811
jrvaldes wants to merge 1 commit into
openshift:masterfrom
jrvaldes:WINC-520-test-releases

Conversation

@jrvaldes
Copy link
Copy Markdown
Contributor

@jrvaldes jrvaldes commented Aug 30, 2022

Before the CI jobs were using Ephemeral OpenShift Releases at run-time
and the resulting images were bundled into the release payload being
tested. With the later approach, there was a mismatch with the version of
the injected oc client.

This change proposes the Existing OpenShift Releases as they are intended
to test software that is not part of OpenShift itself. For example, optional
operators where WMCO is a valid use case. See https://docs.ci.openshift.org/docs/architecture/ci-operator/#should-i-use-an-ephemeral-or-published-release

Ran:

   make update

Follow-up to:

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 30, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jrvaldes
Copy link
Copy Markdown
Contributor Author

/test ?

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 30, 2022

@jrvaldes: The following commands are available to trigger required jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build-clusters
  • /test build01-dry
  • /test build02-dry
  • /test build03-dry
  • /test build04-dry
  • /test build05-dry
  • /test check-gh-automation
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-secret-bootstrap-config-validation
  • /test ci-testgrid-allow-list
  • /test config
  • /test core-valid
  • /test correctly-sharded-config
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test hive-dry
  • /test jira-lifecycle-config
  • /test openshift-image-mirror-mappings
  • /test ordered-prow-config
  • /test owners
  • /test pj-rehearse-blocking
  • /test pr-reminder-config
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test pylint
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test sync-rover-groups
  • /test yamllint

The following commands are available to trigger optional jobs:

  • /test arm01-dry
  • /test pj-rehearse
  • /test pj-rehearse-max
  • /test pj-rehearse-more
  • /test vsphere-dry

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-release-check-gh-automation
  • pull-ci-openshift-release-master-build-clusters
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-config-metadata
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-config
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-correctly-sharded-config
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-generated-config
  • pull-ci-openshift-release-master-ordered-prow-config
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-pj-rehearse
  • pull-ci-openshift-release-master-prow-config-filenames
  • pull-ci-openshift-release-master-prow-config-semantics
  • pull-ci-openshift-release-openshift-image-mirror-mappings
  • pull-ci-openshift-release-yamllint
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jrvaldes
Copy link
Copy Markdown
Contributor Author

/test pj-rehearse

@jrvaldes jrvaldes force-pushed the WINC-520-test-releases branch from dea14a6 to 5e74362 Compare August 31, 2022 02:41
@jrvaldes
Copy link
Copy Markdown
Contributor Author

/test pj-rehearse-more

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 31, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrvaldes
Once this PR has been reviewed and has the lgtm label, please assign sebsoto for approval by writing /assign @sebsoto in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jrvaldes jrvaldes force-pushed the WINC-520-test-releases branch from 060cd6a to 3baa2ee Compare August 31, 2022 12:55
Before the CI jobs were using Ephemeral OpenShift Releases at run-time
and the resulting images were bundled into the release payload being
tested. With the later approach, there was a mismatch with the version of
the injected oc client.

This change proposes the Existing OpenShift Releases as they are intended
to test software that is not part of OpenShift itself. For example, optional
operators where WMCO is a valid use case. See https://docs.ci.openshift.org/docs/architecture/ci-operator/#should-i-use-an-ephemeral-or-published-release

Ran:
```
   make update
```

Follow-up to openshift@a692d58
@jrvaldes jrvaldes force-pushed the WINC-520-test-releases branch from 3baa2ee to 80a8cab Compare August 31, 2022 12:56
@jrvaldes jrvaldes changed the title WIP: Use candidate releases WINC-520: Use Existing OpenShift Releases for CI jobs Aug 31, 2022
@jrvaldes jrvaldes marked this pull request as ready for review August 31, 2022 12:58
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2022
@openshift-ci openshift-ci Bot requested review from aravindhp and sebsoto August 31, 2022 12:58
name: "4.12"
namespace: ocp
candidate:
product: ocp
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do the same for community

@aravindhp
Copy link
Copy Markdown
Contributor

/hold

I am not sure we want to be using released OCP versions in our tests. If we want to pick up a OVN or Machine API change that is yet to be published in our e2e tests, we will have to wait for a release to happen. Unless I am misunderstanding what is meant Existing OpenShift Releases.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 31, 2022

@jrvaldes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/windows-machine-config-operator/master/aws-e2e-ccm-install dea14a67a46493615e679308d4e1cf56f919e6cb link unknown /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/master/azure-e2e-ccm-install dea14a67a46493615e679308d4e1cf56f919e6cb link unknown /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/release-4.9/aws-e2e-upgrade 060cd6a6161c3575851f43dc7cbd25252ebf8a9f link unknown /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/release-4.10/platform-none-vsphere-e2e-operator 80a8cab link unknown /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/release-4.10/azure-e2e-ccm-install 80a8cab link unknown /test pj-rehearse
ci/prow/pj-rehearse-more 060cd6a6161c3575851f43dc7cbd25252ebf8a9f link false /test pj-rehearse-more
ci/rehearse/openshift/windows-machine-config-operator/release-4.10/aws-e2e-upgrade 80a8cab link unknown /test pj-rehearse
ci/prow/pj-rehearse 80a8cab link false /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/release-4.9/platform-none-vsphere-e2e-operator 060cd6a6161c3575851f43dc7cbd25252ebf8a9f link unknown /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/release-4.10/vsphere-e2e-operator 060cd6a6161c3575851f43dc7cbd25252ebf8a9f link unknown /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/release-4.10/aws-e2e-ccm-install 80a8cab link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jrvaldes
Copy link
Copy Markdown
Contributor Author

@jrvaldes jrvaldes closed this Aug 31, 2022
@openshift-ci openshift-ci Bot closed this Aug 31, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 31, 2022

@jrvaldes: Closed this PR.

Details

In response to this:

/close

See openshift/windows-machine-config-operator#1216 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jrvaldes jrvaldes deleted the WINC-520-test-releases branch April 2, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants