Skip to content

Fixes the input images replacement for the initial layers of the fedora-coreos image#31971

Closed
aleskandro wants to merge 1 commit intoopenshift:masterfrom
aleskandro:fix-fcos
Closed

Fixes the input images replacement for the initial layers of the fedora-coreos image#31971
aleskandro wants to merge 1 commit intoopenshift:masterfrom
aleskandro:fix-fcos

Conversation

@aleskandro
Copy link
Copy Markdown
Member

Hi @LorbusChris, the fedora-coreos image is based on the processed Dockerfile.template from the layering-build image (Dockerfile.ci)...

I see that Dockerfile.template essentially rebuilds the image okd-rpms in the third stage based on two layers (the artifacts and machine-config-operator tags) that are not replaced by the prow config...

IIUC, we may want to either change the lines 1-9 of the okd-machine-os' Dockerfile.template to be FROM registry.ci.openshift.org/origin/4.12:okd-rpms AS rpms or the prow config for the fedora-coreos image as in this PR. Or is it a wanted behavior?

Refers #31663

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 3, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aleskandro
Once this PR has been reviewed and has the lgtm label, please assign lorbuschris for approval by writing /assign @lorbuschris in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs
Copy link
Copy Markdown
Contributor

vrutkovs commented Sep 3, 2022

I see that Dockerfile.template essentially rebuilds the image okd-rpms in the third stage based on two layers (the artifacts and machine-config-operator tags) that are not replaced by the prow config...

Right, we'll want to get rid of that

@aleskandro
Copy link
Copy Markdown
Member Author

Ok, so should I close this one?

@vrutkovs
Copy link
Copy Markdown
Contributor

vrutkovs commented Sep 3, 2022

Yeah, I think so. We want to extract MCO binary from okd-rpms, so that it would the single source of RPMs and binaries

@aleskandro
Copy link
Copy Markdown
Member Author

Ok, thanks @vrutkovs ... Closing

@aleskandro aleskandro closed this Sep 3, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 3, 2022

@aleskandro: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/okd-machine-os/release-4.13/images edab3a0 link unknown /test pj-rehearse
ci/rehearse/openshift/okd-machine-os/release-4.13/e2e-gcp edab3a0 link unknown /test pj-rehearse
ci/rehearse/openshift/okd-machine-os/release-4.13/e2e-gcp-upgrade edab3a0 link unknown /test pj-rehearse
ci/rehearse/openshift/okd-machine-os/release-4.13/e2e-aws edab3a0 link unknown /test pj-rehearse
ci/rehearse/openshift/okd-machine-os/release-4.13/e2e-vsphere edab3a0 link unknown /test pj-rehearse
ci/rehearse/openshift/okd-machine-os/release-4.13/e2e-ovirt edab3a0 link unknown /test pj-rehearse
ci/rehearse/openshift/okd-machine-os/release-4.13/e2e-aws-crun edab3a0 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aleskandro aleskandro deleted the fix-fcos branch December 19, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants