Skip to content

Conversation

@jluhrsen
Copy link
Contributor

@jluhrsen jluhrsen commented Nov 3, 2022

fix test flake that checks if the job name matches the running CNI, which is ovnk in 4.12+

also added platform -aws- to these jobs as needed.

jobs were found using this search:

❯ w3m -dump -cols 200
"https://search.ci.openshift.org/?maxAge=96h&type=junit&search=job+name.*does+not+have+network+type+in+name.*expected.*ovn" | sed -n 's/^([^ ]*) .failures match./\1/p' | rg 'cluster-kube-apiserver-operator'
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws-serial pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-upgrade pull-ci-openshift-cluster-kube-apiserver-operator-release-4.12-e2e-aws-serial pull-ci-openshift-cluster-kube-apiserver-operator-release-4.12-e2e-aws-single-node pull-ci-openshift-cluster-kube-apiserver-operator-release-4.12-e2e-upgrade

Signed-off-by: Jamo Luhrsen jluhrsen@gmail.com

fix test flake that checks if the job name matches the running CNI,
which is ovnk in 4.12+

also added platform -aws- to these jobs as needed.

jobs were found using this search:

❯ w3m -dump -cols 200
"https://search.ci.openshift.org/?maxAge=96h&type=junit&search=job+name.*does+not+have+network+type+in+name.*expected.*ovn"
| sed -n 's/^\([^ ]*\) .*failures match.*/\1/p' | rg
'cluster-kube-apiserver-operator'
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws-serial
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-upgrade
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.12-e2e-aws-serial
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.12-e2e-aws-single-node
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.12-e2e-upgrade

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@openshift-ci-robot
Copy link
Contributor

@jluhrsen: the following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws-ovn-serial openshift/cluster-kube-apiserver-operator presubmit Presubmit changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws-ovn-single-node openshift/cluster-kube-apiserver-operator presubmit Presubmit changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws-ovn-upgrade openshift/cluster-kube-apiserver-operator presubmit Presubmit changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.12-e2e-aws-ovn-serial openshift/cluster-kube-apiserver-operator presubmit Presubmit changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.12-e2e-aws-ovn-single-node openshift/cluster-kube-apiserver-operator presubmit Presubmit changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.12-e2e-aws-ovn-upgrade openshift/cluster-kube-apiserver-operator presubmit Presubmit changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.13-e2e-aws-ovn-serial openshift/cluster-kube-apiserver-operator presubmit Presubmit changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.13-e2e-aws-ovn-single-node openshift/cluster-kube-apiserver-operator presubmit Presubmit changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.13-e2e-aws-ovn-upgrade openshift/cluster-kube-apiserver-operator presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals

@openshift-ci openshift-ci bot requested review from soltysh and sttts November 3, 2022 18:11
@jluhrsen
Copy link
Contributor Author

jluhrsen commented Nov 3, 2022

/test pj-rehearse

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Nov 3, 2022

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2022

@jluhrsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-kube-apiserver-operator/release-4.13/e2e-aws-ovn-upgrade 2fbb373 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-kube-apiserver-operator/release-4.12/e2e-aws-ovn-serial 2fbb373 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor

deads2k commented Nov 5, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jluhrsen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2022
@openshift-merge-robot openshift-merge-robot merged commit 620662d into openshift:master Nov 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2022

@jluhrsen: Updated the following 6 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-kube-apiserver-operator-master.yaml using file ci-operator/config/openshift/cluster-kube-apiserver-operator/openshift-cluster-kube-apiserver-operator-master.yaml
  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-kube-apiserver-operator-release-4.12.yaml using file ci-operator/config/openshift/cluster-kube-apiserver-operator/openshift-cluster-kube-apiserver-operator-release-4.12.yaml
  • ci-operator-4.13-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-kube-apiserver-operator-release-4.13.yaml using file ci-operator/config/openshift/cluster-kube-apiserver-operator/openshift-cluster-kube-apiserver-operator-release-4.13.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-kube-apiserver-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-kube-apiserver-operator/openshift-cluster-kube-apiserver-operator-master-presubmits.yaml
  • job-config-4.12 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-kube-apiserver-operator-release-4.12-presubmits.yaml using file ci-operator/jobs/openshift/cluster-kube-apiserver-operator/openshift-cluster-kube-apiserver-operator-release-4.12-presubmits.yaml
  • job-config-4.13 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-kube-apiserver-operator-release-4.13-presubmits.yaml using file ci-operator/jobs/openshift/cluster-kube-apiserver-operator/openshift-cluster-kube-apiserver-operator-release-4.13-presubmits.yaml
Details

In response to this:

fix test flake that checks if the job name matches the running CNI, which is ovnk in 4.12+

also added platform -aws- to these jobs as needed.

jobs were found using this search:

❯ w3m -dump -cols 200
"https://search.ci.openshift.org/?maxAge=96h&type=junit&search=job+name.*does+not+have+network+type+in+name.*expected.*ovn" | sed -n 's/^([^ ]*) .failures match./\1/p' | rg 'cluster-kube-apiserver-operator'
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws-serial pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-upgrade pull-ci-openshift-cluster-kube-apiserver-operator-release-4.12-e2e-aws-serial pull-ci-openshift-cluster-kube-apiserver-operator-release-4.12-e2e-aws-single-node pull-ci-openshift-cluster-kube-apiserver-operator-release-4.12-e2e-upgrade

Signed-off-by: Jamo Luhrsen jluhrsen@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ascerra pushed a commit to ascerra/release that referenced this pull request Nov 7, 2022
)

fix test flake that checks if the job name matches the running CNI,
which is ovnk in 4.12+

also added platform -aws- to these jobs as needed.

jobs were found using this search:

❯ w3m -dump -cols 200
"https://search.ci.openshift.org/?maxAge=96h&type=junit&search=job+name.*does+not+have+network+type+in+name.*expected.*ovn"
| sed -n 's/^\([^ ]*\) .*failures match.*/\1/p' | rg
'cluster-kube-apiserver-operator'
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws-serial
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-upgrade
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.12-e2e-aws-serial
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.12-e2e-aws-single-node
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.12-e2e-upgrade

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@jluhrsen jluhrsen deleted the ovn-4-cluster-kube-apiserver-operator branch January 13, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants