Skip to content

Add myself as upgrade-related step registry content approver#33932

Merged
openshift-merge-robot merged 2 commits into
openshift:masterfrom
petr-muller:muller-as-upgrade-owner-2
Nov 14, 2022
Merged

Add myself as upgrade-related step registry content approver#33932
openshift-merge-robot merged 2 commits into
openshift:masterfrom
petr-muller:muller-as-upgrade-owner-2

Conversation

@petr-muller
Copy link
Copy Markdown
Member

@petr-muller petr-muller commented Nov 10, 2022

I now do upgrades and I know CI

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 10, 2022

@petr-muller: no rehearsable tests are affected by this change

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 10, 2022
@petr-muller petr-muller mentioned this pull request Nov 10, 2022
Merged
@petr-muller
Copy link
Copy Markdown
Member Author

petr-muller commented Nov 10, 2022

/label tide/merge-method-squash

@openshift-ci openshift-ci Bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 10, 2022
@bbguimaraes
Copy link
Copy Markdown
Contributor

bbguimaraes commented Nov 14, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbguimaraes, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 14, 2022

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0572613 into openshift:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@hongkailiu hongkailiu Awaiting requested review from hongkailiu

Assignees

@bbguimaraes bbguimaraes

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@petr-muller @openshift-ci-robot @bbguimaraes @openshift-merge-robot