Skip to content

CAPO: use rhel8 base image to run unit tests #39007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 9, 2023
Merged

CAPO: use rhel8 base image to run unit tests #39007

openshift-merge-robot merged 1 commit into from
May 9, 2023

Conversation

@mandre
Copy link
Member

@mandre mandre commented May 4, 2023 •
edited
Loading

The golang-1.17 image is based on centos 7, which is too old for our
needs. Use a rhel8 based image instead.

Also unset GOFLAGS to remove -mod=vendor since that prevents us from
building envtest, and set XDG variables to workaround permission issues.

@mandre
Copy link
Member Author

mandre commented May 4, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2023
@mandre mandre mentioned this pull request May 4, 2023
Closed
@mandre
Copy link
Member Author

mandre commented May 4, 2023

/pj-rehearse

@mandre
Copy link
Member Author

mandre commented May 4, 2023

/pj-rehearse

@mandre
Copy link
Member Author

mandre commented May 4, 2023

/pj-rehearse

@mandre
Copy link
Member Author

mandre commented May 5, 2023

/pj-rehearse

@mandre
Copy link
Member Author

mandre commented May 9, 2023

/pj-rehearse

@mandre
CAPO: use rhel8 base image to run unit tests
14488c8 
The golang-1.17 image is based on centos 7, which is too old for our
needs. Use a rhel8 based image instead.

Also unset GOFLAGS to remove `-mod=vendor` since that prevents us from
building envtest, and set XDG variables to workaround permission issues.
@mandre mandre changed the title CAPO: Use go 1.18 to run unit tests CAPO: use rhel8 base image to run unit tests May 9, 2023
@mandre
Copy link
Member Author

mandre commented May 9, 2023

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 9, 2023

[REHEARSALNOTIFIER]
@mandre: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-api-provider-openstack-main-unit openshift/cluster-api-provider-openstack presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mandre
Copy link
Member Author

mandre commented May 9, 2023

/pj-rehearse

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2023

@mandre: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandre
Copy link
Member Author

mandre commented May 9, 2023

This is ready for review
/hold cancel
/assign @pierreprinetti

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2023
pierreprinetti
pierreprinetti reviewed May 9, 2023
View reviewed changes
.../openshift/cluster-api-provider-openstack/openshift-cluster-api-provider-openstack-main.yaml
tests:
- as: unit
commands: make test
commands: GOFLAGS= XDG_DATA_HOME=/tmp/.local/share XDG_CACHE_HOME=/tmp/.cache make
Copy link
Member

@pierreprinetti pierreprinetti May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we vendor dependencies (as a downstream patch) and remove the GOFLAGS override?

Copy link
Member Author

@mandre mandre May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly, but since we're only using CAPO as a library in MAPO (we vendor in MAPO), is it important?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandre
Copy link
Member Author

mandre commented May 9, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 9, 2023
@mandre
Copy link
Member Author

mandre commented May 9, 2023

/pj-rehearse ack

@openshift-merge-robot openshift-merge-robot merged commit 9bac374 into openshift:master May 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2023

@mandre: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-cluster-api-provider-openstack-main.yaml using file ci-operator/config/openshift/cluster-api-provider-openstack/openshift-cluster-api-provider-openstack-main.yaml
Details

In response to this:

The golang-1.17 image is based on centos 7, which is too old for our
needs. Use a rhel8 based image instead.

Also unset GOFLAGS to remove -mod=vendor since that prevents us from
building envtest, and set XDG variables to workaround permission issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the capo-image branch May 9, 2023 14:11
@mandre mandre mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephenfin stephenfin Awaiting requested review from stephenfin

1 more reviewer

@pierreprinetti pierreprinetti pierreprinetti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pierreprinetti pierreprinetti

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mandre @openshift-ci-robot @pierreprinetti @openshift-merge-robot