Skip to content

OSSM-3733: Add istio operator postsubmit jobs#39163

Merged
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
yxun:OSSM-3733
May 15, 2023
Merged

OSSM-3733: Add istio operator postsubmit jobs#39163
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
yxun:OSSM-3733

Conversation

@yxun
Copy link
Copy Markdown
Contributor

@yxun yxun commented May 9, 2023

No description provided.

@yxun
Add istio operator postsubmit jobs
3085aec 
Signed-off-by: Yuanlin <yuanlin.xu@redhat.com>
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 9, 2023 •
edited by openshift-ci bot
Loading

@yxun: This pull request references OSSM-3733 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 9, 2023

@yxun, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from base revision of release repo: could not checkout worktree: '[git checkout 14ddb4e7dc647d07c66ff41ef8bb0a174413a9ef]' failed with out: fatal: reference is not a tree: 14ddb4e7dc647d07c66ff41ef8bb0a174413a9ef
and error exit status 128
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from FilipB and jwendell May 9, 2023 15:03
@yxun
Copy link
Copy Markdown
Contributor Author

yxun commented May 9, 2023

/pj-rehearse

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2023
jwendell
jwendell suggested changes May 15, 2023
View reviewed changes
ci-operator/config/maistra/istio-operator/maistra-istio-operator-maistra-2.2.yaml Outdated
-r istio-operator \
-b maistra-2.4 \
-f /creds-github/token \
'-c make clean update-charts-2.1 update-charts-2.2 update-charts-2.3' \
Copy link
Copy Markdown
Member

@jwendell jwendell May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work. Operator 2.2 doesn't know about 2.3 charts.

ci-operator/config/maistra/istio-operator/maistra-istio-operator-maistra-2.4.yaml Outdated
-r istio-operator \
-b maistra-2.4 \
-f /creds-github/token \
'-c make clean update-charts-2.1 update-charts-2.2 update-charts-2.3' \
Copy link
Copy Markdown
Member

@jwendell jwendell May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you include 2.4 and remove 2.1?

Copy link
Copy Markdown
Contributor Author

@yxun yxun May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a 2.4 operator ready for update charts ?
I can update that.

@yxun
Copy link
Copy Markdown
Contributor Author

yxun commented May 15, 2023

/pj-rehearse

jwendell
jwendell reviewed May 15, 2023
View reviewed changes
ci-operator/config/maistra/istio-operator/maistra-istio-operator-maistra-2.4.yaml Outdated
memory: 2Gi
timeout: 20m0s
workflow: servicemesh-istio-e2e-aws
- as: update-charts-in-2-4
Copy link
Copy Markdown
Member

@jwendell jwendell May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I don't think we need a 2.4 job.

The whole point of these jobs is to update the latest (i.e., 2.4) charts when previous charts change. Since 2.4 is the latest, it doesn't make sense for it to exist.

@yxun
Copy link
Copy Markdown
Contributor Author

yxun commented May 15, 2023

/pj-rehearse

1 similar comment
@yxun
Copy link
Copy Markdown
Contributor Author

yxun commented May 15, 2023

/pj-rehearse

@jwendell
Copy link
Copy Markdown
Member

jwendell commented May 15, 2023

LGTM. Add the post submit true and I'll approve it

@yxun
Copy link
Copy Markdown
Contributor Author

yxun commented May 15, 2023

/retest

@yxun
Copy link
Copy Markdown
Contributor Author

yxun commented May 15, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 15, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 15, 2023

[REHEARSALNOTIFIER]
@yxun: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwendell, yxun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 15, 2023

@yxun: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3e47f23 into openshift:master May 15, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 15, 2023

@yxun: Updated the following 2 configmaps:

  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key maistra-istio-operator-maistra-2.2.yaml using file ci-operator/config/maistra/istio-operator/maistra-istio-operator-maistra-2.2.yaml
    • key maistra-istio-operator-maistra-2.3.yaml using file ci-operator/config/maistra/istio-operator/maistra-istio-operator-maistra-2.3.yaml
  • job-config-misc configmap in namespace ci at cluster app.ci using the following files:
    • key maistra-istio-operator-maistra-2.2-postsubmits.yaml using file ci-operator/jobs/maistra/istio-operator/maistra-istio-operator-maistra-2.2-postsubmits.yaml
    • key maistra-istio-operator-maistra-2.3-postsubmits.yaml using file ci-operator/jobs/maistra/istio-operator/maistra-istio-operator-maistra-2.3-postsubmits.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yxun yxun deleted the OSSM-3733 branch October 6, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FilipB FilipB Awaiting requested review from FilipB

1 more reviewer

@jwendell jwendell jwendell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jwendell jwendell

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yxun @openshift-ci-robot @jwendell @openshift-merge-robot