Skip to content

HOSTEDCP-966: Gate more Operators on Hypeshift e2e #39246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
May 24, 2023
Merged

HOSTEDCP-966: Gate more Operators on Hypeshift e2e #39246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .../config/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@ base_images:
name: "4.14"
namespace: ocp
tag: base
hypershift-operator:
name: "4.14"
namespace: ocp
tag: hypershift-operator
hypershift-tests:
name: "4.14"
namespace: ocp
tag: hypershift-tests
ocp_builder_rhel-8-golang-1.20-openshift-4.14:
name: builder
namespace: ocp
Expand Down Expand Up @@ -43,6 +51,9 @@ tests:
commands: make test
container:
from: src
- as: e2e-hypershift
steps:
Copy link
Contributor

@candita candita May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add optional: true until we know this doesn't introduce any issues for cluster-ingress-operator CI?

Copy link
Member Author

@enxebre enxebre May 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are actually intentionally setting it as not optional at this point given we're GAing to prevent operators from breaking us at it has happened in the past.
We are doing the same in multiple operators and we are also ci stream promotion blocker now. I think it's a fair organic step and we can always relax it back if it cause unncessary issues. Makes sense?

Copy link
Member Author

@enxebre enxebre May 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the newest example openshift/cluster-ingress-operator#930 where this could have been very valuable.
We need to get this merged asap right after fixing this new issue so teams are able to operate with healthy safety checks that ensure GA level stability.

workflow: hypershift-aws-e2e-external
- as: e2e-aws-ovn
steps:
cluster_profile: aws
Expand Down
11 changes: 11 additions & 0 deletions ...openshift/cluster-node-tuning-operator/openshift-cluster-node-tuning-operator-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@ base_images:
name: "4.14"
namespace: ocp
tag: base
hypershift-operator:
name: "4.14"
namespace: ocp
tag: hypershift-operator
hypershift-tests:
name: "4.14"
namespace: ocp
tag: hypershift-tests
ocp_builder_rhel-8-golang-1.20-openshift-4.14:
name: builder
namespace: ocp
Expand Down Expand Up @@ -61,6 +69,9 @@ tests:
commands: make vet
container:
from: src
- as: e2e-hypershift
steps:
workflow: hypershift-aws-e2e-external
- as: e2e-aws-ovn
steps:
cluster_profile: aws
Expand Down
54 changes: 54 additions & 0 deletions ...nshift/cluster-ingress-operator/openshift-cluster-ingress-operator-master-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,6 +659,60 @@ presubmits:
secret:
secretName: result-aggregator
trigger: (?m)^/test( | .* )e2e-gcp-ovn,?($|\s.*)
- agent: kubernetes
always_run: true
branches:
- ^master$
- ^master-
cluster: build02
context: ci/prow/e2e-hypershift
decorate: true
labels:
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-openshift-cluster-ingress-operator-master-e2e-hypershift
rerun_command: /test e2e-hypershift
spec:
containers:
- args:
- --gcs-upload-secret=/secrets/gcs/service-account.json
- --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson
- --report-credentials-file=/etc/report/credentials
- --secret-dir=/secrets/ci-pull-credentials
- --target=e2e-hypershift
command:
- ci-operator
image: ci-operator:latest
imagePullPolicy: Always
name: ""
resources:
requests:
cpu: 10m
volumeMounts:
- mountPath: /secrets/ci-pull-credentials
name: ci-pull-credentials
readOnly: true
- mountPath: /secrets/gcs
name: gcs-credentials
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
serviceAccountName: ci-operator
volumes:
- name: ci-pull-credentials
secret:
secretName: ci-pull-credentials
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
trigger: (?m)^/test( | .* )e2e-hypershift,?($|\s.*)
- agent: kubernetes
always_run: true
branches:
Expand Down
54 changes: 54 additions & 0 deletions ...luster-node-tuning-operator/openshift-cluster-node-tuning-operator-master-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,60 @@ presubmits:
secret:
secretName: result-aggregator
trigger: (?m)^/test( | .* )e2e-gcp-pao-updating-profile,?($|\s.*)
- agent: kubernetes
always_run: true
branches:
- ^master$
- ^master-
cluster: build02
context: ci/prow/e2e-hypershift
decorate: true
labels:
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-openshift-cluster-node-tuning-operator-master-e2e-hypershift
rerun_command: /test e2e-hypershift
spec:
containers:
- args:
- --gcs-upload-secret=/secrets/gcs/service-account.json
- --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson
- --report-credentials-file=/etc/report/credentials
- --secret-dir=/secrets/ci-pull-credentials
- --target=e2e-hypershift
command:
- ci-operator
image: ci-operator:latest
imagePullPolicy: Always
name: ""
resources:
requests:
cpu: 10m
volumeMounts:
- mountPath: /secrets/ci-pull-credentials
name: ci-pull-credentials
readOnly: true
- mountPath: /secrets/gcs
name: gcs-credentials
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
serviceAccountName: ci-operator
volumes:
- name: ci-pull-credentials
secret:
secretName: ci-pull-credentials
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
trigger: (?m)^/test( | .* )e2e-hypershift,?($|\s.*)
- agent: kubernetes
always_run: true
branches:
Expand Down