Skip to content

ushift: Remove test-payload image and build within ec2 host#40429

Closed
pacevedom wants to merge 3 commits intoopenshift:masterfrom
pacevedom:shiftweek
Closed

ushift: Remove test-payload image and build within ec2 host#40429
pacevedom wants to merge 3 commits intoopenshift:masterfrom
pacevedom:shiftweek

Conversation

@pacevedom
Copy link
Copy Markdown
Contributor

Remove all references to microshift-test-payload image and take advantage of the ec2 host where microshift is installed. Use it to build the rpms and save some time from the image builder in the build cluster.
Doing this change also changed all the base images for the rpm based tests and their dependencies.

@openshift-ci openshift-ci bot requested review from copejon and dhellmann June 18, 2023 20:50
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2023
@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-microshift-e2e pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced

1 similar comment
@pmtk
Copy link
Copy Markdown
Member

pmtk commented Jun 19, 2023

/pj-rehearse pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-microshift-e2e pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced

@pmtk
Copy link
Copy Markdown
Member

pmtk commented Jun 20, 2023

/pj-rehearse pull-ci-openshift-microshift-release-4.13-e2e-router-smoke-test pull-ci-openshift-microshift-release-4.12-e2e-router-smoke-test

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@pmtk: job(s): either don't exist or were not found to be affected, and cannot be rehearsed

@pmtk
Copy link
Copy Markdown
Member

pmtk commented Jun 20, 2023

/pj-rehearse more

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-microshift-e2e

@pmtk
Copy link
Copy Markdown
Member

pmtk commented Jul 3, 2023

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-release-4.12-e2e-router-smoke-test pull-ci-openshift-microshift-main-microshift-metal-tests

@pacevedom
Copy link
Copy Markdown
Contributor Author

PTAL https://github.com/openshift/microshift/pull/1951/files#diff-8852daecec3ead41a3def231ae3a3376cbae01858790680d6004dc1df2829b89R46

yeah, this change impacts #40720, but that is something that is going to happen anyway

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-microshift-metal-tests

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-microshift-metal-tests pull-ci-openshift-microshift-main-microshift-e2e pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced

@pacevedom
Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2023
@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-microshift-metal-tests

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-microshift-e2e pull-ci-openshift-microshift-main-microshift-metal-tests pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced

1 similar comment
@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-microshift-e2e pull-ci-openshift-microshift-main-microshift-metal-tests pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-microshift-e2e pull-ci-openshift-microshift-main-microshift-metal-tests pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced

1 similar comment
@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-microshift-e2e pull-ci-openshift-microshift-main-microshift-metal-tests pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-test-rebase

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-test-rebase

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-test-rebase

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-test-rebase

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-test-rebase

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-test-rebase

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-test-rebase

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-test-rebase

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@pacevedom: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced-arm openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-images openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-microshift-e2e openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-microshift-e2e-arm openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-microshift-metal-tests openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-microshift-metal-tests-arm openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-test-rebase openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-test-srpm openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-test-unit openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-verify openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.13-e2e-greenboot openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.13-e2e-greenboot-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.13-e2e-loadbalancer-smoke-test openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.13-e2e-loadbalancer-smoke-test-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.15-microshift-metal-tests openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.15-microshift-metal-tests-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.14-microshift-metal-tests openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.14-microshift-metal-tests-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.15-microshift-e2e openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.15-microshift-e2e-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.14-microshift-e2e openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.14-microshift-e2e-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.12-e2e-openshift-conformance-reduced openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.15-e2e-openshift-conformance-reduced openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.15-e2e-openshift-conformance-reduced-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.14-e2e-openshift-conformance-reduced openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.14-e2e-openshift-conformance-reduced-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.13-e2e-openshift-conformance-reduced openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.13-e2e-openshift-conformance-reduced-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.12-e2e-reboot openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.13-e2e-reboot openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.13-e2e-reboot-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.12-e2e-router-smoke-test openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.13-e2e-router-smoke-test openshift/microshift presubmit Registry content changed

A total of 43 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@pacevedom
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-microshift-main-test-rebase

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 31, 2023

@pacevedom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/microshift/main/microshift-e2e-arm ce83cb9c213cfb5eb428b90247b7e0a8696fa727 link unknown /pj-rehearse pull-ci-openshift-microshift-main-microshift-e2e-arm
ci/rehearse/openshift/microshift/main/microshift-metal-tests-arm ce83cb9c213cfb5eb428b90247b7e0a8696fa727 link unknown /pj-rehearse pull-ci-openshift-microshift-main-microshift-metal-tests-arm
ci/rehearse/openshift/microshift/main/e2e-openshift-conformance-reduced-arm ce83cb9c213cfb5eb428b90247b7e0a8696fa727 link unknown /pj-rehearse pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced-arm
ci/rehearse/openshift/microshift/main/test-rebase 5b94972 link unknown /pj-rehearse pull-ci-openshift-microshift-main-test-rebase

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 22, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2023
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 7, 2023
@pacevedom pacevedom closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants