Skip to content

Add 4.14 upgrade rollback job#43401

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shellyyang1989:4.14-rollback
Sep 27, 2023
Merged

Add 4.14 upgrade rollback job#43401
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shellyyang1989:4.14-rollback

Conversation

@shellyyang1989
Copy link
Copy Markdown
Contributor

@shellyyang1989 shellyyang1989 commented Sep 15, 2023

As 4.14.0-rc.0 is available, add 4.14 upgrade rollback job.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want the usual reporter_config in here, right? Compare #41525

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also a 4.14 informer entry, along the lines of #39488?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Trevor! Added. PTAL

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want an "optional": true, in here to catch up with #43370.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you!

wking added a commit to wking/openshift-release that referenced this pull request Sep 21, 2023
4.14, becasue we want to freeze these through the life of 4.14,
following the existing pattern, most recently d666767
(ci-operator/config/openshift/release/openshift-release-master__nightly-4.13:
Add oldest-* jobs, 2023-04-26, openshift#38728).  I'm not pulling in the
rollback job this time, because that's moving under QE and is in
flight separately in [1].

I'm also adding a 4.15 cred-freeze job this time, to catch up with
dbcbb85 (add explanation of blocking jobs in master before service
streams, 2023-09-18, openshift#43418).  As I pointed out in d666767, I'm
still concerned about the amount of churn that I expect will land
during the engineering candidate, but I'm not on the release-oversight
team, and if they perfer having a blocker job in the development
branch with occasional pin bumps, that's fine with me.

The bulk of the ci-operator/jobs content is from:

  $ make jobs

But then I manually edited to inject reporter_config, as described in
08db24d (ci-operator/jobs/openshift/release: Ping @Patch-Manager
for cred-freeze failures, 2021-12-08, openshift#24177).

[1]: openshift#43401
@shellyyang1989 shellyyang1989 force-pushed the 4.14-rollback branch 3 times, most recently from 55549cc to e13cd99 Compare September 24, 2023 13:33
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@shellyyang1989: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-sdn-cgroupsv2 N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-csi N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-ovn-dualstack-local-gateway N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-vsphere-ipi-ovn-cgroupsv1 N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-gcp-libvirt-cert-rotation N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ovn-sno-cert-rotation-suspend-360d N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-ovn-single-node N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-ovn-fips N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ovn-ha-cert-rotation-shutdown-360d N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-gcp-sdn-upgrade N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-upgrade-from-stable-4.13-e2e-vsphere-zones-upgrade N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-azure-upgrade-cnv N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-serial-ovn-ipv6 N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ovn-sno-cert-rotation-shutdown-30d N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ovn-sno-cert-rotation-shutdown-60d N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-vsphere-sdn N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ovn-ha-cert-rotation-shutdown-30d N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ovn-sno-cert-rotation-suspend-60d N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-vsphere-ovn-techpreview-serial N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-driver-toolkit N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-upgrade-from-stable-4.13-e2e-vsphere-upgrade N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ovn-sno-cert-rotation-shutdown-360d N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ovn-sno-cert-rotation-suspend-90d N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-ovn-shared-vpc-phz-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-upgrade-from-stable-4.13-e2e-metal-ipi-sdn-bm-upgrade N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-telco5g-sno-cnftests N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-azure-ovn-cgroupsv1 N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-ovn-serial N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ovn-ha-cert-rotation-suspend-360d N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-alibaba-ovn N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-gcp-ovn-etcd-scaling N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-gcp-ovn-fips N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ovn-sno-cert-rotation-shutdown-180d N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-gcp-graceful-shutdown N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-ovn-cgroupsv1 N/A periodic Ci-operator config changed

A total of 116 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@shellyyang1989
Copy link
Copy Markdown
Contributor Author

cc @jianlinliu @jiajliu for review. Thank you

@jianlinliu
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2023
Copy link
Copy Markdown
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@shellyyang1989
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 27, 2023
@shellyyang1989
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-ovn-upgrade-rollback-oldest-supported

@shellyyang1989
Copy link
Copy Markdown
Contributor Author

/pj-rehearse reject

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 27, 2023
@shellyyang1989
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 27, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, jianlinliu, shellyyang1989, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
@openshift-merge-robot openshift-merge-robot merged commit 7d73044 into openshift:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants