Skip to content

Installer: decouple installer-artifacts#46337

Closed
r4f4 wants to merge 1 commit intoopenshift:masterfrom
r4f4:pr/38975
Closed

Installer: decouple installer-artifacts#46337
r4f4 wants to merge 1 commit intoopenshift:masterfrom
r4f4:pr/38975

Conversation

@r4f4
Copy link
Copy Markdown
Contributor

@r4f4 r4f4 commented Dec 2, 2023

Removes the depenendcy in installer-artifacts on the installer image in order to allow the images to be built in parallel.

Removes the depenendcy in installer-artifacts on the installer
image in order to allow the images to be built in parallel.
@openshift-ci openshift-ci Bot requested review from andfasano and rwsu December 2, 2023 10:39
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@r4f4: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-master-agent-integration-tests openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-custom-security-groups openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-fips openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-imdsv2 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-localzones openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-proxy openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-public-subnets openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-shared-vpc openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-shared-vpc-localzones openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-shared-vpc-wavelengthzones openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-single-node openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-upgrade openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-upi openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-wavelengthzones openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-upi-proxy openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-azure-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-azure-ovn-resourcegroup openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-azure-ovn-shared-vpc openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-vsphere-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-vsphere-static-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-vsphere-zones openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-images openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-aro-unit openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-agent-compact-ipv4 openshift/installer presubmit Ci-operator config changed

A total of 120 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@r4f4
Copy link
Copy Markdown
Contributor Author

r4f4 commented Dec 2, 2023

/pj-rehearse pull-ci-openshift-installer-master-images

1 similar comment
@r4f4
Copy link
Copy Markdown
Contributor Author

r4f4 commented Dec 2, 2023

/pj-rehearse pull-ci-openshift-installer-master-images

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 2, 2023

@r4f4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/installer/master/images 9f2fd60 link unknown /pj-rehearse pull-ci-openshift-installer-master-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link
Copy Markdown
Contributor Author

r4f4 commented Dec 2, 2023

Before:

INFO[2023-11-30T16:47:29Z] Building installer 
INFO[2023-11-30T16:47:29Z] Created build "installer-amd64"
INFO[2023-11-30T16:59:51Z] Build installer-amd64 succeeded after 12m10s 
INFO[2023-11-30T16:59:51Z] Building installer-artifacts                 
INFO[2023-11-30T16:59:51Z] Created build "installer-artifacts-amd64"
INFO[2023-11-30T17:50:41Z] Build installer-artifacts-amd64 succeeded after 50m50s

After

INFO[2023-12-02T12:40:40Z] Building installer-artifacts                 
INFO[2023-12-02T12:40:40Z] Created build "installer-artifacts-amd64"
INFO[2023-12-02T12:40:40Z] Building installer
INFO[2023-12-02T12:40:40Z] Created build "installer-amd64"
INFO[2023-12-02T12:58:27Z] Build installer-amd64 succeeded after 16m5s
INFO[2023-12-02T13:40:24Z] Build installer-artifacts-amd64 succeeded after 58m54s

@r4f4
Copy link
Copy Markdown
Contributor Author

r4f4 commented Dec 2, 2023

/close

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 2, 2023

@r4f4: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot closed this Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants