cert-rotation: emulate cluster age#48502

Merged

openshift-merge-bot[bot] merged 6 commits intoopenshift:masterfrom

vrutkovs:cert-rotation-skip-time

Feb 15, 2024

Contributor

vrutkovs commented Feb 6, 2024

No description provided.

openshift-ci bot added the do-not-merge/work-in-progress label

Contributor

openshift-ci bot commented Feb 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Contributor Author

vrutkovs commented Feb 6, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-90d periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-30d periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-60d

openshift-ci bot added the approved label

vrutkovs changed the title ~~cert-rotation: remove useless + when setting time skew~~ cert-rotation: emulate clsuter age

vrutkovs force-pushed the cert-rotation-skip-time branch from d223543 to b7e3cee Compare

February 6, 2024 16:09

Contributor Author

vrutkovs commented Feb 6, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-90d

vrutkovs force-pushed the cert-rotation-skip-time branch from b7e3cee to 4d27ebb Compare

February 6, 2024 17:34

Contributor Author

vrutkovs commented Feb 6, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-90d

1 similar comment

Contributor Author

vrutkovs commented Feb 6, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-90d

vrutkovs force-pushed the cert-rotation-skip-time branch from 4d27ebb to 2176052 Compare

February 6, 2024 22:52

Contributor Author

vrutkovs commented Feb 6, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-90d

vrutkovs force-pushed the cert-rotation-skip-time branch from 2176052 to 00e4ce8 Compare

February 7, 2024 06:57

Contributor Author

vrutkovs commented Feb 7, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-90d

1 similar comment

Contributor Author

vrutkovs commented Feb 7, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-90d

vrutkovs force-pushed the cert-rotation-skip-time branch from 0ba9207 to 4151299 Compare

February 7, 2024 12:41

Contributor Author

vrutkovs commented Feb 7, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-60d

vrutkovs force-pushed the cert-rotation-skip-time branch from 4151299 to 864b712 Compare

February 7, 2024 15:00

Contributor Author

vrutkovs commented Feb 7, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-90d

1 similar comment

Contributor Author

vrutkovs commented Feb 7, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-90d

vrutkovs force-pushed the cert-rotation-skip-time branch from 8ddfcde to 7c46347 Compare

February 7, 2024 17:32

Contributor Author

vrutkovs commented Feb 7, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-90d

vrutkovs force-pushed the cert-rotation-skip-time branch from 7c46347 to f991d62 Compare

February 7, 2024 18:35

Contributor Author

vrutkovs commented Feb 7, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-90d

vrutkovs force-pushed the cert-rotation-skip-time branch from f991d62 to 0829c69 Compare

February 8, 2024 07:20

Contributor Author

vrutkovs commented Feb 8, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-90d

Contributor Author

vrutkovs commented Feb 8, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-90d periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-30d periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-60d

Contributor Author

vrutkovs commented Feb 8, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-90d-age-90d periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-180d-age-90d periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-1y-age-90d periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-2y-age-90d

1 similar comment

Contributor Author

vrutkovs commented Feb 8, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-90d-age-90d periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-180d-age-90d periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-1y-age-90d periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-2y-age-90d

Contributor Author

vrutkovs commented Feb 8, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-90d-age-90d

openshift-ci bot removed the do-not-merge/work-in-progress label

Contributor Author

vrutkovs commented Feb 14, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-90d-age-90d periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-180d-age-90d periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-1y-age-90d periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-2y-age-90d

openshift-ci bot requested review from benluddy and deepsm007

February 14, 2024 09:45

Vadim Rutkovsky added 4 commits

February 14, 2024 10:50


          Add tests which simulate cluster shutdown at different ages

f5de4a3


          cert-rotation: emulate cluster age

ba63c7e

Fix


          Rework CSR approval

f5384aa


          cert-rotation: store common functions, reuse in different steps

e434dcc

vrutkovs force-pushed the cert-rotation-skip-time branch from c0a18be to e434dcc Compare

February 14, 2024 09:50

Contributor Author

vrutkovs commented Feb 14, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-90d-age-90d periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-180d-age-90d periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-1y-age-90d periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-2y-age-90d

Contributor Author

vrutkovs commented Feb 14, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-2y-age-90d

Contributor Author

vrutkovs commented Feb 14, 2024

/pj-rehearse ack

openshift-ci-robot added the rehearsals-ack label


          cert-rotation: parametrize skew step when emulating cluster age

b37e03e

Contributor Author

vrutkovs commented Feb 14, 2024

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-1y-age-90d periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-2y-age-90d

openshift-ci-robot removed the rehearsals-ack label

Contributor

openshift-ci-robot commented Feb 14, 2024

[REHEARSALNOTIFIER]
@vrutkovs: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-ha-cert-rotation-shutdown-180d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-ha-cert-rotation-shutdown-360d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-ha-cert-rotation-shutdown-90d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-ha-cert-rotation-suspend-180d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-ha-cert-rotation-suspend-360d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-ha-cert-rotation-suspend-90d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-sno-cert-rotation-shutdown-180d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-sno-cert-rotation-shutdown-360d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-sno-cert-rotation-shutdown-90d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-sno-cert-rotation-suspend-180d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-sno-cert-rotation-suspend-1y	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-sno-cert-rotation-suspend-2y	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-sno-cert-rotation-suspend-3y	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-sno-cert-rotation-suspend-90d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-ovn-ha-cert-rotation-shutdown-180d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-ovn-ha-cert-rotation-shutdown-360d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-ovn-ha-cert-rotation-shutdown-90d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-ovn-ha-cert-rotation-suspend-180d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-ovn-ha-cert-rotation-suspend-360d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-ovn-ha-cert-rotation-suspend-90d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-ovn-sno-cert-rotation-shutdown-180d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-ovn-sno-cert-rotation-shutdown-360d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-ovn-sno-cert-rotation-shutdown-90d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-ovn-sno-cert-rotation-suspend-180d	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-ovn-sno-cert-rotation-suspend-1y	openshift/cluster-kube-apiserver-operator	presubmit	Ci-operator config changed

A total of 133 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Contributor

openshift-ci bot commented Feb 14, 2024 •

edited

Loading

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-30d	`0829c69`	link	unknown	`/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-30d-age-30d`
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-2y-age-90d	`b37e03e`	link	unknown	`/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-2y-age-90d`
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-180d-age-90d	`e434dcc`	link	unknown	`/pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-180d-age-90d`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor Author

vrutkovs commented Feb 14, 2024

/pj-rehearse ack

openshift-ci-robot added the rehearsals-ack label

dinhxuanvu approved these changes

View reviewed changes

Member

dinhxuanvu left a comment

/lgtm

openshift-ci bot assigned dinhxuanvu

openshift-ci bot added the lgtm label

Contributor

openshift-ci bot commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/cluster-kube-apiserver-operator/OWNERS~~ [dinhxuanvu,vrutkovs]
~~ci-operator/config/openshift/release/OWNERS~~ [vrutkovs]
~~ci-operator/jobs/openshift/release/OWNERS~~ [vrutkovs]
~~ci-operator/step-registry/openshift/e2e/aws/cert-rotation/OWNERS~~ [dinhxuanvu,vrutkovs]
~~ci-operator/step-registry/openshift/e2e/cert-rotation/OWNERS~~ [dinhxuanvu,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

openshift-ci-robot commented Feb 15, 2024

/retest-required

Remaining retests: 0 against base HEAD b0c826c and 2 for PR HEAD b37e03e in total

openshift-merge-bot bot merged commit a549d4f into openshift:master

mshitrit pushed a commit to mshitrit/release that referenced this pull request


          cert-rotation: emulate cluster age (openshift#48502)

a50f298

* cert-rotation: remove useless + when setting time skew

* Add tests which simulate cluster shutdown at different ages

* cert-rotation: emulate cluster age

Fix

* Rework CSR approval

* cert-rotation: store common functions, reuse in different steps

* cert-rotation: parametrize skew step when emulating cluster age

shaior pushed a commit to natifridman/release that referenced this pull request


          cert-rotation: emulate cluster age (openshift#48502)

59c83ee

* cert-rotation: remove useless + when setting time skew

* Add tests which simulate cluster shutdown at different ages

* cert-rotation: emulate cluster age

Fix

* Rework CSR approval

* cert-rotation: store common functions, reuse in different steps

* cert-rotation: parametrize skew step when emulating cluster age

sgoveas pushed a commit to sgoveas/release that referenced this pull request


          cert-rotation: emulate cluster age (openshift#48502)

7d5a4a8

* cert-rotation: remove useless + when setting time skew

* Add tests which simulate cluster shutdown at different ages

* cert-rotation: emulate cluster age

Fix

* Rework CSR approval

* cert-rotation: store common functions, reuse in different steps

* cert-rotation: parametrize skew step when emulating cluster age

memodi pushed a commit to memodi/release that referenced this pull request


          cert-rotation: emulate cluster age (openshift#48502)

dbcb8d2

* cert-rotation: remove useless + when setting time skew

* Add tests which simulate cluster shutdown at different ages

* cert-rotation: emulate cluster age

Fix

* Rework CSR approval

* cert-rotation: store common functions, reuse in different steps

* cert-rotation: parametrize skew step when emulating cluster age

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm rehearsals-ack