-
Notifications
You must be signed in to change notification settings - Fork 2.1k
periodics: add assisted launch job #48700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
periodics: add assisted launch job #48700
Conversation
861af70 to
64475a2
Compare
|
[REHEARSALNOTIFIER] Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/cc @bradmwilliams |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bradmwilliams, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vrutkovs: Updated the
DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vrutkovs: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* periodics: add assisted launch job * workflows-config: update platform for cert-rotation workflows
* periodics: add assisted launch job * workflows-config: update platform for cert-rotation workflows
* periodics: add assisted launch job * workflows-config: update platform for cert-rotation workflows
…er to "no-capabilities" Similar to bbb31f9 (OCPQE-19978: Add CloudControllerManager Cap for v416, 2024-03-27, openshift#49708), because [1] explains: disabling CloudControllerManager is only supported on the Baremetal, None, or External platform with cloudControllerManager value none Besides the release periodics, I'm also touching the cluster-bot job definitions in openshift-release-infra-periodics.yaml. AWS, Azure, and GCP will all need this new capability. I'm not clear on the packet-assisted job from 6544a41 (periodics: add assisted launch job, 2024-02-12, openshift#48700), and I cannot figure out the Cluster Bot launch syntax to trigger that path. So for now, I'm adding the new capability there too, to avoid forking the configuration without a clearer understanding of the context. This change will break these Cluster Bot jobs for 4.15 and earlier, where the new capability does not exist or match the ClusterVersion enum. But they're already generally available, so folks may not need access, and if they do, hackery like 428ef75 (ci-operator/jobs/openshift/release/openshift-release-infra-periodics: Temporarily drop MachineAPI from Azure Cluster Bot job, 2023-10-23, openshift#44751) can restore it. [1]: openshift/installer@2dc1ef8
…er to "no-capabilities" (#51070) Similar to bbb31f9 (OCPQE-19978: Add CloudControllerManager Cap for v416, 2024-03-27, #49708), because [1] explains: disabling CloudControllerManager is only supported on the Baremetal, None, or External platform with cloudControllerManager value none Besides the release periodics, I'm also touching the cluster-bot job definitions in openshift-release-infra-periodics.yaml. AWS, Azure, and GCP will all need this new capability. I'm not clear on the packet-assisted job from 6544a41 (periodics: add assisted launch job, 2024-02-12, #48700), and I cannot figure out the Cluster Bot launch syntax to trigger that path. So for now, I'm adding the new capability there too, to avoid forking the configuration without a clearer understanding of the context. This change will break these Cluster Bot jobs for 4.15 and earlier, where the new capability does not exist or match the ClusterVersion enum. But they're already generally available, so folks may not need access, and if they do, hackery like 428ef75 (ci-operator/jobs/openshift/release/openshift-release-infra-periodics: Temporarily drop MachineAPI from Azure Cluster Bot job, 2023-10-23, #44751) can restore it. [1]: openshift/installer@2dc1ef8
…er to "no-capabilities" (openshift#51070) Similar to bbb31f9 (OCPQE-19978: Add CloudControllerManager Cap for v416, 2024-03-27, openshift#49708), because [1] explains: disabling CloudControllerManager is only supported on the Baremetal, None, or External platform with cloudControllerManager value none Besides the release periodics, I'm also touching the cluster-bot job definitions in openshift-release-infra-periodics.yaml. AWS, Azure, and GCP will all need this new capability. I'm not clear on the packet-assisted job from 6544a41 (periodics: add assisted launch job, 2024-02-12, openshift#48700), and I cannot figure out the Cluster Bot launch syntax to trigger that path. So for now, I'm adding the new capability there too, to avoid forking the configuration without a clearer understanding of the context. This change will break these Cluster Bot jobs for 4.15 and earlier, where the new capability does not exist or match the ClusterVersion enum. But they're already generally available, so folks may not need access, and if they do, hackery like 428ef75 (ci-operator/jobs/openshift/release/openshift-release-infra-periodics: Temporarily drop MachineAPI from Azure Cluster Bot job, 2023-10-23, openshift#44751) can restore it. [1]: openshift/installer@2dc1ef8
No description provided.