Skip to content

Conversation

@vrutkovs
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 12, 2024
@vrutkovs vrutkovs force-pushed the workflow-assisted-packet branch from 861af70 to 64475a2 Compare February 12, 2024 15:33
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@vrutkovs: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from droslean and wking February 12, 2024 15:41
@vrutkovs
Copy link
Contributor Author

/cc @bradmwilliams

@openshift-ci openshift-ci bot requested a review from bradmwilliams February 12, 2024 15:48
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ad2693b into openshift:master Feb 12, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

@vrutkovs: Updated the ci-chat-bot-workflows-config configmap in namespace ci at cluster app.ci using the following files:

  • key workflows-config.yaml using file core-services/ci-chat-bot/workflows-config.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

@vrutkovs: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mshitrit pushed a commit to mshitrit/release that referenced this pull request Feb 13, 2024
* periodics: add assisted launch job

* workflows-config: update platform for cert-rotation workflows
shaior pushed a commit to natifridman/release that referenced this pull request Feb 14, 2024
* periodics: add assisted launch job

* workflows-config: update platform for cert-rotation workflows
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
* periodics: add assisted launch job

* workflows-config: update platform for cert-rotation workflows
wking added a commit to wking/openshift-release that referenced this pull request Apr 17, 2024
…er to "no-capabilities"

Similar to bbb31f9 (OCPQE-19978: Add CloudControllerManager Cap for
v416, 2024-03-27, openshift#49708), because [1] explains:

  disabling CloudControllerManager is only supported on the Baremetal, None, or External platform with cloudControllerManager value none

Besides the release periodics, I'm also touching the cluster-bot job
definitions in openshift-release-infra-periodics.yaml.  AWS, Azure,
and GCP will all need this new capability.  I'm not clear on the
packet-assisted job from 6544a41 (periodics: add assisted launch
job, 2024-02-12, openshift#48700), and I cannot figure out the Cluster Bot
launch syntax to trigger that path.  So for now, I'm adding the new
capability there too, to avoid forking the configuration without a
clearer understanding of the context.

This change will break these Cluster Bot jobs for 4.15 and earlier,
where the new capability does not exist or match the ClusterVersion
enum.  But they're already generally available, so folks may not need
access, and if they do, hackery like 428ef75
(ci-operator/jobs/openshift/release/openshift-release-infra-periodics:
Temporarily drop MachineAPI from Azure Cluster Bot job, 2023-10-23,
openshift#44751) can restore it.

[1]: openshift/installer@2dc1ef8
openshift-merge-bot bot pushed a commit that referenced this pull request Apr 18, 2024
…er to "no-capabilities" (#51070)

Similar to bbb31f9 (OCPQE-19978: Add CloudControllerManager Cap for
v416, 2024-03-27, #49708), because [1] explains:

  disabling CloudControllerManager is only supported on the Baremetal, None, or External platform with cloudControllerManager value none

Besides the release periodics, I'm also touching the cluster-bot job
definitions in openshift-release-infra-periodics.yaml.  AWS, Azure,
and GCP will all need this new capability.  I'm not clear on the
packet-assisted job from 6544a41 (periodics: add assisted launch
job, 2024-02-12, #48700), and I cannot figure out the Cluster Bot
launch syntax to trigger that path.  So for now, I'm adding the new
capability there too, to avoid forking the configuration without a
clearer understanding of the context.

This change will break these Cluster Bot jobs for 4.15 and earlier,
where the new capability does not exist or match the ClusterVersion
enum.  But they're already generally available, so folks may not need
access, and if they do, hackery like 428ef75
(ci-operator/jobs/openshift/release/openshift-release-infra-periodics:
Temporarily drop MachineAPI from Azure Cluster Bot job, 2023-10-23,
#44751) can restore it.

[1]: openshift/installer@2dc1ef8
saifshaikh48 pushed a commit to saifshaikh48/release that referenced this pull request Apr 23, 2024
…er to "no-capabilities" (openshift#51070)

Similar to bbb31f9 (OCPQE-19978: Add CloudControllerManager Cap for
v416, 2024-03-27, openshift#49708), because [1] explains:

  disabling CloudControllerManager is only supported on the Baremetal, None, or External platform with cloudControllerManager value none

Besides the release periodics, I'm also touching the cluster-bot job
definitions in openshift-release-infra-periodics.yaml.  AWS, Azure,
and GCP will all need this new capability.  I'm not clear on the
packet-assisted job from 6544a41 (periodics: add assisted launch
job, 2024-02-12, openshift#48700), and I cannot figure out the Cluster Bot
launch syntax to trigger that path.  So for now, I'm adding the new
capability there too, to avoid forking the configuration without a
clearer understanding of the context.

This change will break these Cluster Bot jobs for 4.15 and earlier,
where the new capability does not exist or match the ClusterVersion
enum.  But they're already generally available, so folks may not need
access, and if they do, hackery like 428ef75
(ci-operator/jobs/openshift/release/openshift-release-infra-periodics:
Temporarily drop MachineAPI from Azure Cluster Bot job, 2023-10-23,
openshift#44751) can restore it.

[1]: openshift/installer@2dc1ef8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants