Skip to content

Yamllint for rhtap-installer repo #48991

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
xinredhat:yamllint-rhtap-installer
Feb 20, 2024
Merged

Yamllint for rhtap-installer repo #48991
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
xinredhat:yamllint-rhtap-installer

Conversation

@xinredhat
Copy link
Copy Markdown
Contributor

@xinredhat xinredhat commented Feb 20, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from jduimovich and otaviof February 20, 2024 05:15
@xinredhat
Copy link
Copy Markdown
Contributor Author

xinredhat commented Feb 20, 2024

/pj-rehearse pull-ci-redhat-appstudio-rhtap-installer-main-rhtap-installer-yamllint

@xinredhat xinredhat marked this pull request as draft February 20, 2024 05:17
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2024
@xinredhat
Copy link
Copy Markdown
Contributor Author

xinredhat commented Feb 20, 2024

/retest

@xinredhat xinredhat force-pushed the yamllint-rhtap-installer branch from 28e8564 to e8f4664 Compare February 20, 2024 07:30
@xinredhat
Copy link
Copy Markdown
Contributor Author

xinredhat commented Feb 20, 2024

/pj-rehearse pull-ci-redhat-appstudio-rhtap-installer-main-rhtap-installer-yamllint

@xinredhat
yamllint for rhtap-installer repo
6c2c7d6 
rh-pre-commit.version: 2.1.0
rh-pre-commit.check-secrets: ENABLED
@xinredhat xinredhat force-pushed the yamllint-rhtap-installer branch from e8f4664 to 6c2c7d6 Compare February 20, 2024 07:58
@xinredhat xinredhat marked this pull request as ready for review February 20, 2024 07:59
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 20, 2024

[REHEARSALNOTIFIER]
@xinredhat: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-redhat-appstudio-rhtap-installer-main-rhtap-installer-yamllint redhat-appstudio/rhtap-installer presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@xinredhat
Copy link
Copy Markdown
Contributor Author

xinredhat commented Feb 20, 2024

/pj-rehearse pull-ci-redhat-appstudio-rhtap-installer-main-rhtap-installer-yamllint

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 20, 2024

@xinredhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/redhat-appstudio/rhtap-installer/main/rhtap-installer-yamllint 6c2c7d6 link unknown /pj-rehearse pull-ci-redhat-appstudio-rhtap-installer-main-rhtap-installer-yamllint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@prietyc123
Copy link
Copy Markdown
Contributor

prietyc123 commented Feb 20, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
@xinredhat
Copy link
Copy Markdown
Contributor Author

xinredhat commented Feb 20, 2024

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 20, 2024
@prietyc123
Copy link
Copy Markdown
Contributor

prietyc123 commented Feb 20, 2024

/approve

@otaviof
Copy link
Copy Markdown
Member

otaviof commented Feb 20, 2024

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: otaviof, prietyc123, xinredhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 91f97b5 into openshift:master Feb 20, 2024
sgoveas pushed a commit to sgoveas/release that referenced this pull request Feb 22, 2024
@xinredhat @sgoveas
yamllint for rhtap-installer repo (openshift#48991)
fedf868 
rh-pre-commit.version: 2.1.0
rh-pre-commit.check-secrets: ENABLED
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
@xinredhat @memodi
yamllint for rhtap-installer repo (openshift#48991)
2fd8abf 
rh-pre-commit.version: 2.1.0
rh-pre-commit.check-secrets: ENABLED
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jduimovich jduimovich Awaiting requested review from jduimovich

@otaviof otaviof Awaiting requested review from otaviof

Assignees

@otaviof otaviof

@prietyc123 prietyc123

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xinredhat @openshift-ci-robot @prietyc123 @otaviof