Skip to content

Added a list of software that's required to run builds.#596

Closed
twiest wants to merge 1 commit into
openshift:masterfrom
twiest:pr
Closed

Added a list of software that's required to run builds.#596
twiest wants to merge 1 commit into
openshift:masterfrom
twiest:pr

Conversation

@twiest
Copy link
Copy Markdown

@twiest twiest commented Feb 15, 2018

It's sometimes difficult to know what packages need to be installed in order for the standard go-lang build tools to work properly.

Also, sometimes the errors that are generated from missing packages aren't clear on what's needed to fix them.

This represents the minimum set of packages in order to get a go build, rpm build and image build working.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 15, 2018
@stevekuznetsov
Copy link
Copy Markdown
Contributor

Can we use the os::util::ensure libraries to make the error messages clearer?

@twiest
Copy link
Copy Markdown
Author

twiest commented Feb 15, 2018

@stevekuznetsov the 3 functions I see in os::util::ensure:: are system_binary_exists, gopath_binary_exists and built_binary_exists.

Were you thinking we should add something like system_package_exists ?

@stevekuznetsov
Copy link
Copy Markdown
Contributor

We could probably just look for system_binary -- go, docker, git, whatever -- that would work well in addition to this README to help fix those bad error messages.

@twiest twiest closed this Jul 16, 2018
derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
Fix bug in ipmi address when not using port
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants