Skip to content

bump golangci-lint to latest#60961

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
patrickdillon:bump-golangci
Jan 24, 2025
Merged

bump golangci-lint to latest#60961
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
patrickdillon:bump-golangci

Conversation

@patrickdillon
Copy link
Copy Markdown
Contributor

Switch main branch to use latest version mirrored in CI.

The latest version I see mirrored is v1.62.2, so if we see that version in the rehearsal, it works!

Switch main branch to use latest version mirrored in CI.
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@patrickdillon: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-main-altinfra-e2e-aws-custom-security-groups openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-fips openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-imdsv2 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-localzones openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-proxy openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-shared-vpc openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-shared-vpc-local-zones openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-shared-vpc-wavelength-zones openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-single-node openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-wavelengthzones openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-azure-capi-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-azure-ovn-shared-vpc openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-gcp-capi-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-gcp-ovn-byo-network-capi openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-gcp-ovn-secureboot-capi openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-gcp-ovn-xpn-capi openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-ibmcloud-capi-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-nutanix-capi-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-openstack-capi-ccpmso openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-openstack-capi-ccpmso-zone openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-openstack-capi-dualstack openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-openstack-capi-dualstack-upi openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-openstack-capi-dualstack-v6primary openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-openstack-capi-externallb openshift/installer presubmit Ci-operator config changed

A total of 132 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@patrickdillon
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-installer-main-golint

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@patrickdillon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Copy Markdown
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@patrickdillon
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@patrickdillon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 24, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 24, 2025

@patrickdillon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/installer/main/golint 62db913 link unknown /pj-rehearse pull-ci-openshift-installer-main-golint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 64795c9 into openshift:master Jan 24, 2025
fjglira pushed a commit to fjglira/release that referenced this pull request Feb 5, 2025
Switch main branch to use latest version mirrored in CI.
jtaleric pushed a commit to jtaleric/release that referenced this pull request Feb 10, 2025
Switch main branch to use latest version mirrored in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants