-
Notifications
You must be signed in to change notification settings - Fork 2k
Move cli-ocm into oc #65198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move cli-ocm into oc #65198
Conversation
c48acd8 to
ee925d8
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-oc-master-supplemental-images-images |
|
@danilo-gemoli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danilo-gemoli, deepsm007 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Issues in openshift/release go stale after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
@danilo-gemoli: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Stale issue in openshift/release rot after 15d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues in openshift/release close after 15d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We have been building
cli-ocmvia aBuildConfigand push it intoregistry.ci.openshift.org.Folks use this image into their
ci-operatorconfigurations like so:and the image gets resolved from
quay.io/openshift/ci:ci_cli-ocm_latest.This means that we have to trigger a
BuildConfigand then manually push the outcome intoquay.iomanually, every time someone needs a new version of this image.By moving it into the
ci-operator'sopenshift/occonfiguration, the whole mechanism of building and pushing will be handled entirely byci-operator.As a final yet important note: this PR isn't enough by itself.ci-operatoris going to promote the image to:whereas thebase_images(see the snipped right above) pulls it from:If we want to go down this route we have to follow this up with another PR and update a bunch ofci-operatorconfigurations, such as thebase_imageswould look like so: