Skip to content

Update rebasebot test image#65749

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
RadekManak:rebasebot-image
Jun 11, 2025
Merged

Update rebasebot test image#65749
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
RadekManak:rebasebot-image

Conversation

@RadekManak
Copy link
Contributor

@RadekManak RadekManak commented Jun 5, 2025

Updates the rebasebot test image to ubi10-minimal, python3.12, installs uv for python dependency management.

I am working on a tooling overhaul that assumes uv is installed.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2025
@openshift-ci openshift-ci bot requested review from elmiko and nrb June 5, 2025 19:17
@RadekManak
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-eng-rebasebot-main-images pull-ci-openshift-eng-rebasebot-main-lint pull-ci-openshift-eng-rebasebot-main-unit

@openshift-ci-robot
Copy link
Contributor

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@nrb
Copy link
Contributor

nrb commented Jun 5, 2025

I am working on a tooling overhaul that assumes uv is installed.

What do we gain by using uv? I know it's implemented in Rust and I believe it also provides built-in support for virtualenvs.

I'm not opposed, just curious what the benefits are.

@RadekManak
Copy link
Contributor Author

RadekManak commented Jun 5, 2025

What do we gain by using uv?
The venv support is great. All make targets automatically run in the correct venv. Build and tests uses different venv with only the required dependencies. Everything is configured in one place in pyproject.toml. It is super fast. Additionally, with ruff linting is also much faster, and has almost every linter ever created in single package. uv is not even required if all you want to do is pip install.

@RadekManak
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-eng-rebasebot-main-images pull-ci-openshift-eng-rebasebot-main-lint pull-ci-openshift-eng-rebasebot-main-unit

@openshift-ci-robot
Copy link
Contributor

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@nrb
Copy link
Contributor

nrb commented Jun 5, 2025

Good call on Ruff, too. I also knew that there was the new pyproject.toml standard, but haven't dove into any the tools like Poetry or uv.

👍 to simplifying the array of tools, especially since most of our team isn't Python experts.

@RadekManak
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-eng-rebasebot-main-images pull-ci-openshift-eng-rebasebot-main-lint pull-ci-openshift-eng-rebasebot-main-unit

@openshift-ci-robot
Copy link
Contributor

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RadekManak
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-eng-rebasebot-main-images pull-ci-openshift-eng-rebasebot-main-lint pull-ci-openshift-eng-rebasebot-main-unit

@openshift-ci-robot
Copy link
Contributor

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RadekManak
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-eng-rebasebot-main-images pull-ci-openshift-eng-rebasebot-main-lint pull-ci-openshift-eng-rebasebot-main-unit

@openshift-ci-robot
Copy link
Contributor

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@RadekManak: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-eng-rebasebot-main-images openshift-eng/rebasebot presubmit Ci-operator config changed
pull-ci-openshift-eng-rebasebot-main-lint openshift-eng/rebasebot presubmit Ci-operator config changed
pull-ci-openshift-eng-rebasebot-main-unit openshift-eng/rebasebot presubmit Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cloud-provider-powervs N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cloud-provider-ibm N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cloud-provider-vsphere N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cluster-api N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cluster-api-provider-gcp N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-openstack-ironic N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-kubernetes-nmstate N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-autoscaling-karpenter-provider-aws N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-openstack-ironic-inspector N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-tempo-operator N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-kubernetes-autoscaler N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-openstack-sushy N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cloud-provider-vpc-controller N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-openstack-ironic-python-agent N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-openstack-ironic-lib N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-jaeger-operator N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cluster-api-provider-azure N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cluster-api-provider-vsphere N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cloud-provider-aws N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cloud-provider-azure N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cluster-api-provider-aws N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cluster-api-provider-ibmcloud N/A periodic Ci-operator config changed

A total of 29 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@RadekManak
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-eng-rebasebot-main-images pull-ci-openshift-eng-rebasebot-main-lint pull-ci-openshift-eng-rebasebot-main-unit

@openshift-ci-robot
Copy link
Contributor

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2025

@RadekManak: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@RadekManak
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 10, 2025
@nrb
Copy link
Contributor

nrb commented Jun 11, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb, RadekManak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6db3bef into openshift:master Jun 11, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants