Skip to content

Update the aws custom-dns pre-submit job as techPreview and also with skipped tests#68299

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
gpei:sync_update_aws
Aug 21, 2025
Merged

Update the aws custom-dns pre-submit job as techPreview and also with skipped tests#68299
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
gpei:sync_update_aws

Conversation

@gpei
Copy link
Copy Markdown
Contributor

@gpei gpei commented Aug 20, 2025

To keep consistent with the GCP changes in #68127

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@gpei: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-main-e2e-aws-custom-dns-techpreview openshift/installer presubmit Presubmit changed
pull-ci-openshift-installer-release-4.20-e2e-aws-custom-dns-techpreview openshift/installer presubmit Presubmit changed
pull-ci-openshift-installer-release-4.21-e2e-aws-custom-dns-techpreview openshift/installer presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jianlinliu
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2025
@gpei
Copy link
Copy Markdown
Contributor Author

gpei commented Aug 20, 2025

since there's a bug blocking the AWS custom-dns installation - https://issues.redhat.com//browse/OCPBUGS-57364, so skip the rehearsal test

@gpei
Copy link
Copy Markdown
Contributor Author

gpei commented Aug 20, 2025

/pj-rehearse skip

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 20, 2025
@yunjiang29
Copy link
Copy Markdown
Contributor

/lgtm

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Aug 21, 2025

We already know that the CIO tests to do with non-default controllers is going to fail at the start. So, OK to seed these tests with the same skip tests as GCP.

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Aug 21, 2025

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gpei, jianlinliu, sadasu, yunjiang29

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 21, 2025

@gpei: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 13747e0 into openshift:master Aug 21, 2025
15 checks passed
JslYoon pushed a commit to JslYoon/openshift-release that referenced this pull request Aug 25, 2025
… skipped tests (openshift#68299)

* mark aws custom-dns job as techPreview with skipped tests

* make update
tbuskey pushed a commit to tbuskey/release that referenced this pull request Aug 26, 2025
… skipped tests (openshift#68299)

* mark aws custom-dns job as techPreview with skipped tests

* make update
etmurasaki pushed a commit to etmurasaki/release that referenced this pull request Sep 3, 2025
… skipped tests (openshift#68299)

* mark aws custom-dns job as techPreview with skipped tests

* make update
xiaojiey pushed a commit to xiaojiey/release that referenced this pull request Sep 9, 2025
… skipped tests (openshift#68299)

* mark aws custom-dns job as techPreview with skipped tests

* make update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants