AGENT-1383: Add agent-iso-builder dependency #72078
Conversation
|
Skipping CI for Draft Pull Request. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@pawanpinjarkar: This pull request references AGENT-1383 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold wait for image promotion #72028 |
openshift-ci
bot
added
the
do-not-merge/hold
pawanpinjarkar
force-pushed
the
add-dependency-on-agent-ove-iso-builder-image
branch
from
ad2ddcf to
aadb466
Compare
pawanpinjarkar
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/hold cancel |
|
/pj-rehearse ack |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-ci-robot
removed
the
rehearsals-ack
|
/pj-rehearse |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
pawanpinjarkar
force-pushed
the
add-dependency-on-agent-ove-iso-builder-image
branch
from
aadb466 to
5d90d94
Compare
|
/uncc |
|
/depends on openshift-metal3/dev-scripts#1820 |
ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh
Show resolved
Hide resolved
|
/pj-rehearse |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
| echo "export APPLIANCE_IMAGE=${APPLIANCE_IMAGE}" >> /root/dev-scripts/config_root.sh | ||
| fi | ||
| echo "export AGENT_ISO_BUILDER_IMAGE=${AGENT_ISO_BUILDER_IMAGE}" >> /root/dev-scripts/config_root.sh |
There was a problem hiding this comment.
we don't want to set this config var always, isn't it? But only when testing the OVE ISO
There was a problem hiding this comment.
This was discussed here #72078 (comment)
There was a problem hiding this comment.
Since this step is shared by many different jobs (ie, not only agent jobs but also metal ones), it would be better to pollute other teams configuration with unwanted/not requested configuration (similarly to what already appliance does at line 393) - given that this is a specific agent config, and not a general one.
There was a problem hiding this comment.
I agree 🙂 Adding it back
pawanpinjarkar
force-pushed
the
add-dependency-on-agent-ove-iso-builder-image
branch
from
78b160a to
a0d8869
Compare
|
/approve |
openshift-ci
bot
added
the
approved
openshift-ci-robot
removed
the
rehearsals-ack
|
[REHEARSALNOTIFIER]
A total of 3166 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse ack |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
/pj-rehearse |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-appliance-release-master-e2e-sno-dualstack-dhcp |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@pawanpinjarkar: job(s): pull-ci-openshift-appliance-release-master-e2e-sno-dualstack-dhcp either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, bfournie, pawanpinjarkar, rwsu, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pawanpinjarkar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 8f7b1ad
into
openshift:master
7 participants
No description provided.