Skip to content

SPLAT-2583: Added techpreview version of vsphere static ip for catching TP breaks #72425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Dec 11, 2025
Merged

SPLAT-2583: Added techpreview version of vsphere static ip for catching TP breaks #72425

openshift-merge-bot merged 1 commit into from
Dec 11, 2025

Conversation

@vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Dec 10, 2025 •
edited
Loading

SPLAT-2583

Changes

  • Created TP vSphere static IP for 4.21 and 4.22

Notes

Adding these jobs due to just now catching that TechPreview is breaking static IP when its enabled.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 10, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 10, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2583 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

SPLAT-2583

Changes

  • Created TP vSphere static IP for 4.21 and 4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 10, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2583 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

SPLAT-2583

Changes

  • Created TP vSphere static IP for 4.21 and 4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dgoodwin and sosiouxme December 10, 2025 16:16
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 10, 2025

[REHEARSALNOTIFIER]
@vr4manta: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn-techpreview N/A periodic Periodic changed
periodic-ci-openshift-release-master-nightly-4.22-e2e-vsphere-static-ovn-techpreview N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mdbooth
Copy link
Contributor

mdbooth commented Dec 10, 2025

/lgtm

@vr4manta
Copy link
Contributor Author

vr4manta commented Dec 10, 2025

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn-techpreview

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 10, 2025

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2025
@vr4manta
Copy link
Contributor Author

vr4manta commented Dec 10, 2025

/assign @dgoodwin

damdo
damdo reviewed Dec 10, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

jluhrsen
jluhrsen reviewed Dec 10, 2025
View reviewed changes
ci-operator/config/openshift/release/openshift-release-master__nightly-4.21.yaml
- observers-resource-watch
workflow: openshift-e2e-vsphere-staticip
- as: e2e-vsphere-static-ovn-techpreview
cron: 45 22 * * 6
Copy link
Contributor

@jluhrsen jluhrsen Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

late saturday night when all should be quiet :)

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 10, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2583 which is a valid jira issue.

Details

In response to this:

SPLAT-2583

Changes

  • Created TP vSphere static IP for 4.21 and 4.22

Notes

Adding these jobs due to just now catching that TechPreview is breaking static IP when its enabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Contributor

jcpowermac commented Dec 10, 2025

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn-techpreview

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 10, 2025

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@neisw
Copy link
Contributor

neisw commented Dec 10, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, mdbooth, neisw, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2025
@mdbooth
Copy link
Contributor

mdbooth commented Dec 10, 2025

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn-techpreview

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 10, 2025

@mdbooth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mdbooth
Copy link
Contributor

mdbooth commented Dec 11, 2025

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn-techpreview

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2025

@mdbooth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mdbooth
Copy link
Contributor

mdbooth commented Dec 11, 2025

We're happy that this fails in the expected manner.
/pj-rehearse ack

Waiting until we're sure we want to merge it
/hold

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2025

@mdbooth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 11, 2025
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2025
@vr4manta
Copy link
Contributor Author

vr4manta commented Dec 11, 2025

/unhold
Unholding so we can use with installer PR

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2025

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn-techpreview 906b45c link unknown /pj-rehearse periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e033184 into openshift:master Dec 11, 2025
15 of 16 checks passed
eifrach pushed a commit to eifrach/release that referenced this pull request Dec 16, 2025
@vr4manta @eifrach
Added techpreview version of vsphere static ip for catching TP breaks (…
198d596 
…openshift#72425)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

@sosiouxme sosiouxme Awaiting requested review from sosiouxme

2 more reviewers

@jluhrsen jluhrsen jluhrsen left review comments

@damdo damdo damdo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dgoodwin dgoodwin

@mdbooth mdbooth

@damdo damdo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@vr4manta @openshift-ci-robot @mdbooth @jcpowermac @neisw @jluhrsen @damdo @dgoodwin