-
Notifications
You must be signed in to change notification settings - Fork 2.1k
CORENET-6697: add konflux shared pull secret into qe-catalogsource to make it as global #73343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…obal Signed-off-by: zhaozhanqi <zzhao@redhat.com>
|
[REHEARSALNOTIFIER]
A total of 8326 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-automated-release-aws-ipi-f999 |
|
@rioliu-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
should |
I think current implementation does not support disconnected env. FBC index image are not mirrored. @zhaozhanqi correct me if I'm wrong |
Thanks @yunjiang29 that's a good question. |
Yes, I just reply that. we can use a separate PR for disconnect cluster so that it does not block level0 testing and I saw all operators cases passed from the CI job |
|
/pj-rehearse ack |
|
@rioliu-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
@yunjiang29 Can you approve this PR, thx |
|
/assign @yunjiang29 @jianlinliu @jianzhangbjz @anpingli |
|
@zhaozhanqi: This pull request references CORENET-6697 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jianlinliu, rioliu-rh, zhaozhanqi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@zhaozhanqi: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
370106a
into
openshift:master
…obal (openshift#73343) Signed-off-by: zhaozhanqi <zzhao@redhat.com>
|
FYI, there is already this step: https://github.com/openshift/release/tree/master/ci-operator/step-registry/deploy-konflux-operator which configures the credentials. It should work in disconnected environment as well. |
as almost all olm operators already move to konflux, here is trying to add konflux shared pull secret as global pull secret of cluster