Skip to content

Conversation

@melvinjoseph86
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@melvinjoseph86
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-vsphere-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-master-e2e-baremetalds-metallb-gatewayapi-conformance

@openshift-ci-robot
Copy link
Contributor

@melvinjoseph86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@melvinjoseph86: job(s): pull-ci-openshift-cluster-ingress-operator-master-e2e-vsphere-gatewayapi-conformance either don't exist or were not found to be affected, and cannot be rehearsed

@melvinjoseph86
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-vsphere-static-gatewayapi-conformance

@openshift-ci-robot
Copy link
Contributor

@melvinjoseph86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@melvinjoseph86
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-ingress-operator-4.20-e2e-vsphere-static-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-4.21-e2e-vsphere-static-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-master-e2e-vsphere-static-gatewayapi-conformance

@openshift-ci-robot
Copy link
Contributor

@melvinjoseph86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@melvinjoseph86: job(s): pull-ci-openshift-cluster-ingress-operator-4.20-e2e-vsphere-static-gatewayapi-conformance, pull-ci-openshift-cluster-ingress-operator-4.21-e2e-vsphere-static-gatewayapi-conformance either don't exist or were not found to be affected, and cannot be rehearsed

@melvinjoseph86
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-ingress-operator-release-4.20-e2e-vsphere-static-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-release-4.21-e2e-vsphere-static-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-master-e2e-vsphere-static-gatewayapi-conformance

@openshift-ci-robot
Copy link
Contributor

@melvinjoseph86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@melvinjoseph86 melvinjoseph86 changed the title Add e2e-vsphere-metallb-gatewayapi-conformance NE-2417: Add e2e-vsphere-metallb-gatewayapi-conformance Jan 19, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 19, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2026

@melvinjoseph86: This pull request references NE-2417 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@melvinjoseph86
Copy link
Contributor Author

/retest-required

@melvinjoseph86
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-ingress-operator-release-4.20-e2e-vsphere-static-gatewayapi-conformance

@openshift-ci-robot
Copy link
Contributor

@melvinjoseph86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@melvinjoseph86 melvinjoseph86 marked this pull request as ready for review January 19, 2026 17:17
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2026
@melvinjoseph86
Copy link
Contributor Author

@lihongan @rikatz Kindly help review

@rikatz
Copy link
Member

rikatz commented Jan 19, 2026

nice one, I am anxious to see this passing.

Would it make sense to also rehearse the baremetal test to be sure it is also passing?

@rikatz
Copy link
Member

rikatz commented Jan 19, 2026

/pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-baremetalds-metallb-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-release-4.21-e2e-baremetalds-metallb-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-release-4.20-e2e-baremetalds-metallb-gatewayapi-conformance

@openshift-ci-robot
Copy link
Contributor

@rikatz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rikatz
Copy link
Member

rikatz commented Jan 19, 2026

/approve
tests on vsphere are passing, let's rehearse on baremetal ones to be sure they wont be broken by this change then lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2026
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 19, 2026
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2026
@melvinjoseph86
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-ingress-operator-release-4.20-e2e-vsphere-static-metallb-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-release-4.21-e2e-vsphere-static-metallb-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-master-e2e-vsphere-static-metallb-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-master-e2e-baremetalds-metallb-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-release-4.21-e2e-baremetalds-metallb-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-release-4.20-e2e-baremetalds-metallb-gatewayapi-conformance

@openshift-ci-robot
Copy link
Contributor

@melvinjoseph86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2026
@melvinjoseph86
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2026
@melvinjoseph86
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-ingress-operator-release-4.20-e2e-vsphere-static-metallb-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-release-4.21-e2e-vsphere-static-metallb-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-master-e2e-vsphere-static-metallb-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-master-e2e-baremetalds-metallb-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-release-4.21-e2e-baremetalds-metallb-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-release-4.20-e2e-baremetalds-metallb-gatewayapi-conformance

@openshift-ci-robot
Copy link
Contributor

@melvinjoseph86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2026
@melvinjoseph86
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-ingress-operator-release-4.20-e2e-vsphere-static-metallb-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-release-4.21-e2e-vsphere-static-metallb-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-master-e2e-vsphere-static-metallb-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-master-e2e-baremetalds-metallb-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-release-4.21-e2e-baremetalds-metallb-gatewayapi-conformance pull-ci-openshift-cluster-ingress-operator-release-4.20-e2e-baremetalds-metallb-gatewayapi-conformance

@openshift-ci-robot
Copy link
Contributor

@melvinjoseph86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@melvinjoseph86: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-ingress-operator-master-e2e-vsphere-static-metallb-gatewayapi-conformance openshift/cluster-ingress-operator presubmit Presubmit changed
pull-ci-openshift-cluster-ingress-operator-release-4.20-e2e-vsphere-static-metallb-gatewayapi-conformance openshift/cluster-ingress-operator presubmit Presubmit changed
pull-ci-openshift-cluster-ingress-operator-release-4.21-e2e-vsphere-static-metallb-gatewayapi-conformance openshift/cluster-ingress-operator presubmit Presubmit changed
pull-ci-openshift-cluster-ingress-operator-master-e2e-baremetalds-metallb-gatewayapi-conformance openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.23-e2e-baremetalds-metallb-gatewayapi-conformance openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.22-e2e-baremetalds-metallb-gatewayapi-conformance openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.21-e2e-baremetalds-metallb-gatewayapi-conformance openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.20-e2e-baremetalds-metallb-gatewayapi-conformance openshift/cluster-ingress-operator presubmit Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 20, 2026
@lihongan
Copy link
Contributor

/pj-rehearse ack
/lgtm

@openshift-ci-robot
Copy link
Contributor

@lihongan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 20, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lihongan, melvinjoseph86, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2026

@melvinjoseph86: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 04746fe into openshift:master Jan 20, 2026
23 checks passed
@melvinjoseph86 melvinjoseph86 deleted the vsphere_metallb branch January 20, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants