Skip to content

Set CLAUDE_PLUGIN_ROOT for review-agent CI job#74539

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
bryan-cox:fix/review-agent-plugin-root
Feb 7, 2026
Merged

Set CLAUDE_PLUGIN_ROOT for review-agent CI job#74539
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
bryan-cox:fix/review-agent-plugin-root

Conversation

@bryan-cox
Copy link
Member

Summary

  • Set CLAUDE_PLUGIN_ROOT environment variable after cloning ai-helpers so the address-reviews command can locate helper scripts (e.g., check_replied.py) at runtime
  • Companion change to openshift-eng/ai-helpers#315 which updated address-reviews to use CLAUDE_PLUGIN_ROOT for path resolution instead of hardcoded paths

Context

The address-reviews command uses check_replied.py to prevent duplicate replies. The CI job clones ai-helpers to /tmp/ai-helpers and feeds the command markdown as --system-prompt — it doesn't use the Claude Code plugin system. Setting CLAUDE_PLUGIN_ROOT=/tmp/ai-helpers/plugins/utils ensures the script is found when the agent runs the duplicate check.

Test plan

  • Verify next periodic review-agent run finds check_replied.py successfully
  • Verify no duplicate replies are posted

🤖 Generated with Claude Code

The address-reviews command now uses ${CLAUDE_PLUGIN_ROOT}/scripts/check_replied.py
to locate a helper script. Export CLAUDE_PLUGIN_ROOT pointing to the utils plugin
directory after cloning ai-helpers so the script path resolves correctly in CI.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2026
@openshift-ci openshift-ci bot requested review from celebdor and sjenning February 6, 2026 18:37
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@bryan-cox: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-main-review-agent-single-pr openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.23-review-agent-single-pr openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.22-review-agent-single-pr openshift/hypershift presubmit Registry content changed
periodic-ci-openshift-hypershift-main-periodic-review-agent N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.22-periodic-review-agent N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@celebdor
Copy link
Contributor

celebdor commented Feb 6, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, celebdor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bryan-cox
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent

@openshift-ci-robot
Copy link
Contributor

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bryan-cox
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 7, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2026

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 98bcec5 into openshift:master Feb 7, 2026
10 checks passed
Sau1506mya pushed a commit to Sau1506mya/release that referenced this pull request Feb 9, 2026
The address-reviews command now uses ${CLAUDE_PLUGIN_ROOT}/scripts/check_replied.py
to locate a helper script. Export CLAUDE_PLUGIN_ROOT pointing to the utils plugin
directory after cloning ai-helpers so the script path resolves correctly in CI.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
mohit-sheth pushed a commit to mohit-sheth/release that referenced this pull request Feb 9, 2026
The address-reviews command now uses ${CLAUDE_PLUGIN_ROOT}/scripts/check_replied.py
to locate a helper script. Export CLAUDE_PLUGIN_ROOT pointing to the utils plugin
directory after cloning ai-helpers so the script path resolves correctly in CI.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants