Skip to content

WINC-1578: Use tests-private-pr for debug-winc-vsphere-ipi verification#74877

Open
weinliu wants to merge 2 commits intoopenshift:mainfrom
weinliu:fix-winc-1578-verify
Open

WINC-1578: Use tests-private-pr for debug-winc-vsphere-ipi verification#74877
weinliu wants to merge 2 commits intoopenshift:mainfrom
weinliu:fix-winc-1578-verify

Conversation

@weinliu
Copy link
Contributor

@weinliu weinliu commented Feb 13, 2026

Summary

Temporary change to verify the fix for WINC-1578 via Prow CI.

The debug-winc-vsphere-ipi test step currently uses ref: openshift-extended-test which runs from the tests-private image (release payload). This means code changes in openshift-tests-private PRs are never reflected in the test binary.

This PR inlines the step with from: tests-private-pr so the test uses the PR-built binary, allowing verification of the WINC-1578 fix in openshift/origin PR #30782.

Related PRs:

Test plan

The debug-winc-vsphere-ipi test step was using the tests-private
image from the release payload, which means PR code changes in
openshift-tests-private were never reflected in the test binary.

Inline the openshift-extended-test step with from: tests-private-pr
so the test runs with the PR-built binary, enabling verification of
WINC-1578 fix (dockercfg timeout on debug clusters).

This is a temporary change for verification purposes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 13, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2026

@weinliu: This pull request references WINC-1578 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

Temporary change to verify the fix for WINC-1578 via Prow CI.

The debug-winc-vsphere-ipi test step currently uses ref: openshift-extended-test which runs from the tests-private image (release payload). This means code changes in openshift-tests-private PRs are never reflected in the test binary.

This PR inlines the step with from: tests-private-pr so the test uses the PR-built binary, allowing verification of the WINC-1578 fix in openshift/origin PR #30782.

Related PRs:

Test plan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: weinliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2026
@openshift-ci openshift-ci bot requested review from liangxia and pruan-rht February 13, 2026 12:21
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 13, 2026
The inlined step needs to declare all env parameters that the job
config overrides (TEST_TIMEOUT, TEST_FILTERS, FORCE_SUCCESS_EXIT,
TEST_SCENARIOS), otherwise ci-operator validation fails.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@weinliu: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

@weinliu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-operator-config-metadata 8a8b940 link true /test ci-operator-config-metadata

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

weinliu added a commit to weinliu/release that referenced this pull request Feb 14, 2026
Inline the openshift-extended-test step with from: tests-private-pr
instead of using the ref, so the test runs with PR-built binary.

This enables verification of the origin PR openshift#30782 fix (WaitForServiceAccountWithSecret
timeout when image-registry pods are unhealthy) before it's merged.

Similar approach to PR openshift#74877. This is temporary for verification.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants