WINC-1578: Use tests-private-pr for debug-winc-vsphere-ipi verification#74877
WINC-1578: Use tests-private-pr for debug-winc-vsphere-ipi verification#74877weinliu wants to merge 2 commits intoopenshift:mainfrom
Conversation
The debug-winc-vsphere-ipi test step was using the tests-private image from the release payload, which means PR code changes in openshift-tests-private were never reflected in the test binary. Inline the openshift-extended-test step with from: tests-private-pr so the test runs with the PR-built binary, enabling verification of WINC-1578 fix (dockercfg timeout on debug clusters). This is a temporary change for verification purposes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@weinliu: This pull request references WINC-1578 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: weinliu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The inlined step needs to declare all env parameters that the job config overrides (TEST_TIMEOUT, TEST_FILTERS, FORCE_SUCCESS_EXIT, TEST_SCENARIOS), otherwise ci-operator validation fails. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@weinliu: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Inline the openshift-extended-test step with from: tests-private-pr instead of using the ref, so the test runs with PR-built binary. This enables verification of the origin PR openshift#30782 fix (WaitForServiceAccountWithSecret timeout when image-registry pods are unhealthy) before it's merged. Similar approach to PR openshift#74877. This is temporary for verification. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Summary
Temporary change to verify the fix for WINC-1578 via Prow CI.
The
debug-winc-vsphere-ipitest step currently usesref: openshift-extended-testwhich runs from thetests-privateimage (release payload). This means code changes inopenshift-tests-privatePRs are never reflected in the test binary.This PR inlines the step with
from: tests-private-prso the test uses the PR-built binary, allowing verification of the WINC-1578 fix in openshift/origin PR #30782.Related PRs:
Test plan
/test debug-winc-vsphere-ipion openshift-tests-private PR Integrate e2e (golang+cucushift) for azure-ipi-sharednetwork #29169