Skip to content

openshift-logging: Update cluster-logging-operator to Go 1.25#75406

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
xperimental:clo-go125
May 6, 2026
Merged

openshift-logging: Update cluster-logging-operator to Go 1.25#75406
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
xperimental:clo-go125

Conversation

@xperimental
Copy link
Copy Markdown
Contributor

@xperimental xperimental commented Feb 26, 2026

  • Updates cluster-logging-operator in master to build with Go 1.25
  • Trying out a different way of getting the builder image into the build (was reminded of this by the LO configuration)
  • e2e tests successful

/cc @jcantrill
/assign @xperimental

Summary by CodeRabbit

  • Chores
    • Updated CI/CD build configuration for improved maintainability
    • Upgraded Go toolchain version from 1.24 to 1.25
    • Optimized container image build process with streamlined dependencies

@xperimental
Copy link
Copy Markdown
Contributor Author

/pj-rehearse more

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@xperimental: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2026
@xperimental
Copy link
Copy Markdown
Contributor Author

/pj-rehearse more

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@xperimental: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-bot
Copy link
Copy Markdown
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 2, 2026
@openshift-bot
Copy link
Copy Markdown
Contributor

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 17, 2026
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

Walkthrough

Updates CI build configuration for the cluster-logging-operator by bumping the Go builder stream tag from version 1.24 to 1.25 (rhel-9-golang), removing explicit base_images.go_builder inputs, and refactoring the e2e image to use from: src build context instead of prior Dockerfile stage definitions.

Changes

Cohort / File(s) Summary
CI Build Configuration
ci-operator/config/openshift/cluster-logging-operator/openshift-cluster-logging-operator-master.yaml
Updated Go builder stream tag from 1.24 to 1.25, removed explicit go_builder base image inputs, refactored e2e image to use from: src build context, and removed prior Dockerfile stage definitions for Go toolset provisioning.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: updating the cluster-logging-operator Go version from 1.24 to 1.25 in the CI configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only modifies CI/CD configuration file, not Ginkgo test code. Custom check for test titles does not apply.
Test Structure And Quality ✅ Passed The Ginkgo test quality check is not applicable to this PR, which only modifies CI configuration YAML without any test code changes.
Microshift Test Compatibility ✅ Passed This PR contains only CI operator configuration changes updating Go builder image tag from 1.24 to 1.25. No new Ginkgo e2e tests are being added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies only CI operator configuration files, updating Go builder version from 1.24 to 1.25. No new Ginkgo e2e tests are added, only CI job configurations referencing existing tests.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies CI build configuration only, not deployment manifests, operator code, or pod specifications with scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR modifies only CI operator configuration YAML file updating Go version tag from 1.24 to 1.25. No Go source code changes that could affect stdout behavior.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR is a CI configuration-only change updating Go builder version from 1.24 to 1.25. No new test code with IPv4 assumptions or external connectivity requirements is introduced.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@xperimental: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-logging-operator-master-ci-index-cluster-logging-operator-bundle openshift/cluster-logging-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-logging-operator-master-e2e-target openshift/cluster-logging-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-logging-operator-master-functional-target openshift/cluster-logging-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-logging-operator-master-images openshift/cluster-logging-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-logging-operator-master-lint openshift/cluster-logging-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-logging-operator-master-unit openshift/cluster-logging-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@xperimental
Copy link
Copy Markdown
Contributor Author

/pj-rehearse more

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@xperimental: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jcantrill
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xperimental
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@xperimental: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 6, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

@xperimental: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 51b568c into openshift:main May 6, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants